Skip to content

Commit 5717c5f

Browse files
committed
[lldb] Re-enable TestDAP_stackTrace on Windows
It's unclear why this test has been disabled on Windows. Remove the unistd.h header and try re-enabling it.
1 parent 82f1f5e commit 5717c5f

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

lldb/test/API/tools/lldb-dap/stackTrace/TestDAP_stackTrace.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ def verify_stackFrame(self, frame_idx, stackFrame):
5656
"frame #%i line %i == %i" % (frame_idx, frame_line, expected_line),
5757
)
5858

59-
@skipIfWindows
6059
def test_stackTrace(self):
6160
"""
6261
Tests the 'stackTrace' packet and all its variants.
@@ -202,7 +201,6 @@ def test_stackTrace(self):
202201
0, len(stackFrames), "verify zero frames with startFrame out of bounds"
203202
)
204203

205-
@skipIfWindows
206204
def test_functionNameWithArgs(self):
207205
"""
208206
Test that the stack frame without a function name is given its pc in the response.
@@ -217,7 +215,6 @@ def test_functionNameWithArgs(self):
217215
frame = self.get_stackFrames()[0]
218216
self.assertEqual(frame["name"], "recurse(x=1)")
219217

220-
@skipIfWindows
221218
def test_StackFrameFormat(self):
222219
"""
223220
Test the StackFrameFormat.
@@ -239,7 +236,7 @@ def test_StackFrameFormat(self):
239236
self.assertEqual(frame["name"], "recurse(x=1)")
240237

241238
frame = self.get_stackFrames(format={"parameters": False, "line": True})[0]
242-
self.assertEqual(frame["name"], "main.c:6:5 recurse")
239+
self.assertEqual(frame["name"], "main.c:5:5 recurse")
243240

244241
frame = self.get_stackFrames(format={"parameters": False, "module": True})[0]
245242
self.assertEqual(frame["name"], "a.out recurse")

lldb/test/API/tools/lldb-dap/stackTrace/main.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include <stdio.h>
2-
#include <unistd.h>
32

43
int recurse(int x) {
54
if (x <= 1)

0 commit comments

Comments
 (0)