Skip to content

Commit 5788ec0

Browse files
author
Kevin Frei
committed
A couple minor tweaks to keep the previous behavior 'available'
1 parent 98082cc commit 5788ec0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -570,8 +570,8 @@ unsigned DWARFVerifier::verifyDieRanges(const DWARFDie &Die,
570570
++NumErrors;
571571
ErrorCategory.Report("Invalid address range", [&]() {
572572
error() << "Invalid address range " << Range << "\n";
573+
DumpDieAfterError = true;
573574
});
574-
DumpDieAfterError = true;
575575
continue;
576576
}
577577

@@ -586,8 +586,8 @@ unsigned DWARFVerifier::verifyDieRanges(const DWARFDie &Die,
586586
ErrorCategory.Report("DIE has overlapping DW_AT_ranges", [&]() {
587587
error() << "DIE has overlapping ranges in DW_AT_ranges attribute: "
588588
<< *PrevRange << " and " << Range << '\n';
589+
DumpDieAfterError = true;
589590
});
590-
DumpDieAfterError = DumpOpts.Verbose;
591591
}
592592
}
593593
if (DumpDieAfterError)
@@ -1058,7 +1058,7 @@ DWARFVerifier::DWARFVerifier(raw_ostream &S, DWARFContext &D,
10581058
DIDumpOptions DumpOpts)
10591059
: OS(S), DCtx(D), DumpOpts(std::move(DumpOpts)), IsObjectFile(false),
10601060
IsMachOObject(false) {
1061-
if (DumpOpts.Verbose) {
1061+
if (DumpOpts.Verbose || !DumpOpts.ShowAggregateErrors) {
10621062
ErrorCategory.EnableDetail();
10631063
}
10641064
if (const auto *F = DCtx.getDWARFObj().getFile()) {

0 commit comments

Comments
 (0)