Skip to content

Commit 57cacb0

Browse files
committed
Flipped intermittent test failures from skip to XFAIL.
The following intermittently-failing tests have been flipped from skip to XFAIL on some combo of Linux and MacOSX: TestCallStopAndContinue.py (Linux, MacOSX) TestCallWithTimeout.py (Linux) TestConvenienceVariables.py (Linux) TestStopHookMultipleThreads.py (Linux) The following new tests have been marked XFAIL but are just intermittently failing: TestMultipleDebug.py (definitely intermittent on MacOSX, not sure I've seen it pass yet on Linux) llvm-svn: 212762
1 parent 1b5adb8 commit 57cacb0

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

lldb/test/api/multiple-debuggers/TestMultipleDebuggers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ def setUp(self):
1616
self.lib_dir = os.environ["LLDB_LIB_DIR"]
1717

1818
@skipIfi386
19+
@expectedFailureDarwin("llvm.org/pr20282") # intermittent
20+
@expectedFailureLinux("llvm.org/pr20282")
1921
def test_multiple_debuggers(self):
2022

2123
self.driver_exe = os.path.join(os.getcwd(), "multi-process-driver")

lldb/test/expression_command/call-function/TestCallStopAndContinue.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ def setUp(self):
2222

2323
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
2424
@dsym_test
25-
@skipIfDarwin # see llvm.org/pr20274 - intermittent failure on MacOSX
25+
@expectedFailureDarwin("llvm.org/pr20274") # intermittent failure on MacOSX
2626
def test_with_dsym(self):
2727
"""Test gathering result from interrupted function call."""
2828
self.buildDsym()
2929
self.call_function()
3030

3131
@dwarf_test
32-
@skipIfDarwin # see llvm.org/pr20274 - intermittent failure on MacOSX
33-
@skipIfLinux # see llvm.org/pr20274 - intermittent failure on Linux
32+
@expectedFailureDarwin("llvm.org/pr20274") # intermittent failure on MacOSX
33+
@expectedFailureLinux("llvm.org/pr20274") # intermittent failure on Linux
3434
def test_with_dwarf(self):
3535
"""Test gathering result from interrupted function call."""
3636
self.buildDwarf()

lldb/test/expression_command/timeout/TestCallWithTimeout.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_with_dsym(self):
2727
self.call_function()
2828

2929
@expectedFailureFreeBSD("llvm.org/pr19605") # fails on buildbot
30-
@skipIfLinux # llvm.org/pr20275 - fails intermittently on Linux
30+
@expectedFailureLinux("llvm.org/pr20275") # fails intermittently on Linux
3131
@dwarf_test
3232
def test_with_dwarf(self):
3333
"""Test calling std::String member function."""

lldb/test/functionalities/embedded_interpreter/TestConvenienceVariables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def test_with_dsym_and_run_command(self):
1919

2020
@dwarf_test
2121
@skipIfFreeBSD # llvm.org/pr17228
22-
@skipIfLinux # llvm.org/pr20276
22+
@expectedFailureLinux("llvm.org/pr20276") # intermittent failure on Linux
2323
def test_with_dwarf_and_run_commands(self):
2424
"""Test convenience variables lldb.debugger, lldb.target, lldb.process, lldb.thread, and lldb.frame."""
2525
self.buildDwarf()

lldb/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def test_stop_hook_multiple_threads_with_dsym(self):
2121
self.stop_hook_multiple_threads()
2222

2323
@dwarf_test
24-
@skipIfLinux # llvm.org/pr15037 stop hooks sometimes fail to fire on Linux (cannot mark XFAIL, sometimes it passes)
24+
@expectedFailureLinux("llvm.org/pr15037") # stop hooks sometimes fail to fire on Linux
2525
def test_stop_hook_multiple_threads_with_dwarf(self):
2626
"""Test that lldb stop-hook works for multiple threads."""
2727
self.buildDwarf(dictionary=self.d)

0 commit comments

Comments
 (0)