Skip to content

Commit 593526f

Browse files
authored
[X86] Use MCRegister instead of int64_t in X86MCExpr. NFC (#106569)
1 parent 049b60c commit 593526f

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2789,7 +2789,7 @@ bool X86AsmParser::parseATTOperand(OperandVector &Operands) {
27892789
if (auto *RE = dyn_cast<X86MCExpr>(Expr)) {
27902790
// Segment Register. Reset Expr and copy value to register.
27912791
Expr = nullptr;
2792-
Reg = RE->getRegNo();
2792+
Reg = RE->getReg();
27932793

27942794
// Check the register.
27952795
if (Reg == X86::EIZ || Reg == X86::RIZ)
@@ -3052,7 +3052,7 @@ bool X86AsmParser::ParseMemOperand(unsigned SegReg, const MCExpr *Disp,
30523052
return true;
30533053

30543054
// Check the register.
3055-
BaseReg = cast<X86MCExpr>(E)->getRegNo();
3055+
BaseReg = cast<X86MCExpr>(E)->getReg();
30563056
if (BaseReg == X86::EIZ || BaseReg == X86::RIZ)
30573057
return Error(BaseLoc, "eiz and riz can only be used as index registers",
30583058
SMRange(BaseLoc, EndLoc));
@@ -3079,7 +3079,7 @@ bool X86AsmParser::ParseMemOperand(unsigned SegReg, const MCExpr *Disp,
30793079
Warning(Loc, "scale factor without index register is ignored");
30803080
Scale = 1;
30813081
} else { // IndexReg Found.
3082-
IndexReg = cast<X86MCExpr>(E)->getRegNo();
3082+
IndexReg = cast<X86MCExpr>(E)->getReg();
30833083

30843084
if (BaseReg == X86::RIP)
30853085
return Error(Loc,

llvm/lib/Target/X86/MCTargetDesc/X86MCExpr.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,31 +26,31 @@ namespace llvm {
2626
class X86MCExpr : public MCTargetExpr {
2727

2828
private:
29-
const int64_t RegNo; // All
29+
const MCRegister Reg; // All
3030

31-
explicit X86MCExpr(int64_t R) : RegNo(R) {}
31+
explicit X86MCExpr(MCRegister R) : Reg(R) {}
3232

3333
public:
3434
/// @name Construction
3535
/// @{
3636

37-
static const X86MCExpr *create(int64_t RegNo, MCContext &Ctx) {
38-
return new (Ctx) X86MCExpr(RegNo);
37+
static const X86MCExpr *create(MCRegister Reg, MCContext &Ctx) {
38+
return new (Ctx) X86MCExpr(Reg);
3939
}
4040

4141
/// @}
4242
/// @name Accessors
4343
/// @{
4444

4545
/// getSubExpr - Get the child of this expression.
46-
int64_t getRegNo() const { return RegNo; }
46+
MCRegister getReg() const { return Reg; }
4747

4848
/// @}
4949

5050
void printImpl(raw_ostream &OS, const MCAsmInfo *MAI) const override {
5151
if (!MAI || MAI->getAssemblerDialect() == 0)
5252
OS << '%';
53-
OS << X86ATTInstPrinter::getRegisterName(RegNo);
53+
OS << X86ATTInstPrinter::getRegisterName(Reg);
5454
}
5555

5656
bool evaluateAsRelocatableImpl(MCValue &Res, const MCAssembler *Asm,
@@ -61,7 +61,7 @@ class X86MCExpr : public MCTargetExpr {
6161
bool inlineAssignedExpr() const override { return true; }
6262
bool isEqualTo(const MCExpr *X) const override {
6363
if (auto *E = dyn_cast<X86MCExpr>(X))
64-
return getRegNo() == E->getRegNo();
64+
return getReg() == E->getReg();
6565
return false;
6666
}
6767
void visitUsedExpr(MCStreamer &Streamer) const override {}

0 commit comments

Comments
 (0)