[lld-link] Simplify warnUnusable. NFC

MaskRay · MaskRay · commit 59bc03cf8e9d · 2024-12-03T22:33:36.000-08:00
diff --git a/lld/COFF/PDB.cpp b/lld/COFF/PDB.cpp
@@ -1006,11 +1006,10 @@ static void warnUnusable(InputFile *f, Error e, bool shouldWarn) {
     consumeError(std::move(e));
     return;
   }
-  auto msg = "Cannot use debug info for '" + toString(f) + "' [LNK4099]";
+  auto diag = Warn(f->ctx);
+  diag << "Cannot use debug info for '" << f << "' [LNK4099]";
   if (e)
-    warn(msg + "\n>>> failed to load reference " + toString(std::move(e)));
-  else
-    warn(msg);
+    diag << "\n>>> failed to load reference " << std::move(e);
 }
 
 // Allocate memory for a .debug$S / .debug$F section and relocate it.

Original file line number	Diff line number	Diff line change
`@@ -1006,11 +1006,10 @@ static void warnUnusable(InputFile *f, Error e, bool shouldWarn) {`
`1006`	`1006`	`consumeError(std::move(e));`
`1007`	`1007`	`return;`
`1008`	`1008`	`}`
`1009`		`- auto msg = "Cannot use debug info for '" + toString(f) + "' [LNK4099]";`
	`1009`	`+ auto diag = Warn(f->ctx);`
	`1010`	`+ diag << "Cannot use debug info for '" << f << "' [LNK4099]";`
`1010`	`1011`	`if (e)`
`1011`		`- warn(msg + "\n>>> failed to load reference " + toString(std::move(e)));`
`1012`		`- else`
`1013`		`- warn(msg);`
	`1012`	`+ diag << "\n>>> failed to load reference " << std::move(e);`
`1014`	`1013`	`}`
`1015`	`1014`
`1016`	`1015`	`// Allocate memory for a .debug$S / .debug$F section and relocate it.`