Skip to content

Commit 5a9bdd8

Browse files
ftynseftynse
authored
[mlir] split transform interfaces into a separate library (#85221)
Transform interfaces are implemented, direction or via extensions, in libraries belonging to multiple other dialects. Those dialects don't need to depend on the non-interface part of the transform dialect, which includes the growing number of ops and transitive dependency footprint. Split out the interfaces into a separate library. This in turn requires flipping the dependency from the interface on the dialect that has crept in because both co-existed in one library. The interface shouldn't depend on the transform dialect either. As a consequence of splitting, the capability of the interpreter to automatically walk the payload IR to identify payload ops of a certain kind based on the type used for the entry point symbol argument is disabled. This is a good move by itself as it simplifies the interpreter logic. This functionality can be trivially replaced by a `transform.structured.match` operation.
1 parent b7324b6 commit 5a9bdd8

File tree

102 files changed

+239
-168
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+239
-168
lines changed

‎mlir/docs/Tutorials/transform/Ch2.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ The operations themselves can be defined using ODS, exactly in the same way as r
6262
#define MY_EXTENSION
6363
6464
include "mlir/Dialect/Transform/IR/TransformDialect.td"
65-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
65+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
6666
include "mlir/IR/OpBase.td"
6767
include "mlir/Interfaces/SideEffectInterfaces.td"
6868
@@ -124,7 +124,7 @@ This will generate two files, `MyExtension.h.inc` and `MyExtension.cpp.inc`, tha
124124
```c++
125125
// In MyExtension.h.
126126
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
127-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
127+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
128128

129129
#define GET_OP_CLASSES
130130
#include "MyExtension.h.inc"

‎mlir/examples/transform/Ch2/include/MyExtension.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
#include "mlir/Bytecode/BytecodeOpInterface.h"
1515
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
16-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
16+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1717

1818
#define GET_OP_CLASSES
1919
#include "MyExtension.h.inc"

‎mlir/examples/transform/Ch2/include/MyExtension.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#define MY_EXTENSION
1616

1717
include "mlir/Dialect/Transform/IR/TransformDialect.td"
18-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
18+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1919
include "mlir/IR/OpBase.td"
2020
include "mlir/Interfaces/SideEffectInterfaces.td"
2121

‎mlir/examples/transform/Ch2/lib/MyExtension.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
#include "mlir/Dialect/Func/IR/FuncOps.h"
1616
#include "mlir/Dialect/SCF/IR/SCF.h"
1717
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
18-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1918
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
19+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
2020
#include "mlir/IR/DialectRegistry.h"
2121
#include "mlir/IR/Operation.h"
2222
#include "mlir/Interfaces/SideEffectInterfaces.h"

‎mlir/examples/transform/Ch3/include/MyExtension.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@
1313

1414
#include "mlir/Bytecode/BytecodeOpInterface.h"
1515
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
16-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
16+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1717

1818
namespace mlir {
1919
class CallOpInterface;
2020
namespace func {
2121
class CallOp;
2222
} // namespace func
23+
namespace transform {
24+
class OperationType;
25+
} // namespace transform
2326
} // namespace mlir
2427

2528
#define GET_TYPEDEF_CLASSES

‎mlir/examples/transform/Ch3/include/MyExtension.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
include "MyExtensionTypes.td"
1818
include "mlir/Dialect/Transform/IR/TransformDialect.td"
19-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
19+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
2020
include "mlir/Dialect/Transform/IR/TransformTypes.td"
2121
include "mlir/IR/OpBase.td"
2222
include "mlir/Interfaces/SideEffectInterfaces.td"

‎mlir/examples/transform/Ch3/include/MyExtensionTypes.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
include "mlir/IR/AttrTypeBase.td"
1818
include "mlir/Dialect/Transform/IR/TransformDialect.td"
19-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
19+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
2020

2121
// Transform dialect allows additional types to be defined and injected.
2222
def CallOpInterfaceHandle

‎mlir/examples/transform/Ch3/lib/MyExtension.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include "mlir/Dialect/Func/IR/FuncOps.h"
1616
#include "mlir/Dialect/SCF/IR/SCF.h"
1717
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
18+
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
1819
#include "mlir/IR/DialectImplementation.h"
1920
#include "mlir/Interfaces/CallInterfaces.h"
2021
#include "llvm/ADT/TypeSwitch.h"

‎mlir/examples/transform/Ch4/include/MyExtension.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
#include "mlir/Bytecode/BytecodeOpInterface.h"
1515
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
16-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1716
#include "mlir/Dialect/Transform/IR/TransformOps.h"
17+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1818

1919
namespace mlir {
2020
class CallOpInterface;

‎mlir/examples/transform/Ch4/include/MyExtension.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
include "mlir/Dialect/Transform/IR/MatchInterfaces.td"
1818
include "mlir/Dialect/Transform/IR/TransformDialect.td"
19-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
19+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
2020
include "mlir/IR/OpBase.td"
2121
include "mlir/Interfaces/SideEffectInterfaces.td"
2222

‎mlir/include/mlir/Dialect/AMDGPU/TransformOps/AMDGPUTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "mlir/Dialect/Func/IR/FuncOps.h"
1313
#include "mlir/Dialect/Transform/IR/TransformAttrs.h"
1414
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
15-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
15+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1616
#include "mlir/IR/OpImplementation.h"
1717
#include "mlir/IR/RegionKindInterface.h"
1818

‎mlir/include/mlir/Dialect/AMDGPU/TransformOps/AMDGPUTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
include "mlir/Dialect/Transform/IR/TransformAttrs.td"
1313
include "mlir/Dialect/Transform/IR/TransformDialect.td"
14-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
14+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1515
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1616

1717
include "mlir/Interfaces/SideEffectInterfaces.td"

‎mlir/include/mlir/Dialect/Affine/TransformOps/AffineTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#define MLIR_DIALECT_AFFINE_TRANSFORMOPS_AFFINETRANSFORMOPS_H
1111

1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
13-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1413
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
14+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1515
#include "mlir/IR/OpImplementation.h"
1616

1717
namespace mlir {

‎mlir/include/mlir/Dialect/Affine/TransformOps/AffineTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define AFFINE_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1515
include "mlir/Interfaces/SideEffectInterfaces.td"
1616
include "mlir/IR/OpBase.td"

‎mlir/include/mlir/Dialect/Bufferization/TransformOps/BufferizationTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
1313
#include "mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h"
14-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1514
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
15+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1616
#include "mlir/IR/OpImplementation.h"
1717

1818
namespace mlir {

‎mlir/include/mlir/Dialect/Bufferization/TransformOps/BufferizationTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
include "mlir/Dialect/Bufferization/IR/BufferizationEnums.td"
1313
include "mlir/Dialect/Transform/IR/TransformDialect.td"
14-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
14+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1515
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1616
include "mlir/Interfaces/SideEffectInterfaces.td"
1717
include "mlir/IR/OpBase.td"

‎mlir/include/mlir/Dialect/Func/TransformOps/FuncTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define MLIR_DIALECT_FUNC_TRANSFORMOPS_FUNCTRANSFORMOPS_H
1111

1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
13-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
13+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1414
#include "mlir/IR/OpImplementation.h"
1515

1616
#define GET_OP_CLASSES

‎mlir/include/mlir/Dialect/Func/TransformOps/FuncTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define FUNC_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1515
include "mlir/Interfaces/SideEffectInterfaces.td"
1616
include "mlir/IR/RegionKindInterface.td"

‎mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define MLIR_DIALECT_GPU_TRANSFORMOPS_GPUTRANSFORMOPS_H
1111

1212
#include "mlir/Dialect/SCF/IR/SCF.h"
13-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
13+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1414
#include "mlir/IR/OpImplementation.h"
1515
#include "mlir/IR/PatternMatch.h"
1616

‎mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define GPU_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Interfaces/SideEffectInterfaces.td"
1515
include "mlir/IR/OpBase.td"
1616

‎mlir/include/mlir/Dialect/GPU/TransformOps/Utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
#include "mlir/Dialect/GPU/IR/GPUDialect.h"
1313
#include "mlir/Dialect/SCF/IR/DeviceMappingInterface.h"
14-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
14+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1515
#include "mlir/IR/OpImplementation.h"
1616
#include "mlir/IR/PatternMatch.h"
1717

‎mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "mlir/Dialect/Linalg/IR/Linalg.h"
1515
#include "mlir/Dialect/Transform/IR/TransformAttrs.h"
1616
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
17-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
17+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1818
#include "mlir/Dialect/Utils/StructuredOpsUtils.h"
1919
#include "mlir/IR/OpImplementation.h"
2020
#include "mlir/IR/RegionKindInterface.h"
@@ -38,6 +38,9 @@ class UnPackOp;
3838
} // namespace tensor
3939

4040
namespace transform {
41+
class AnyOpType;
42+
class AnyValueType;
43+
class OperationType;
4144
class TransformHandleTypeInterface;
4245
// Types needed for builders.
4346
struct TileSizesSpec {};

‎mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
include "mlir/Dialect/Linalg/TransformOps/LinalgTransformEnums.td"
1313
include "mlir/Dialect/Transform/IR/TransformAttrs.td"
1414
include "mlir/Dialect/Transform/IR/TransformDialect.td"
15-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
15+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1616
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1717
include "mlir/Dialect/SCF/IR/DeviceMappingInterface.td"
1818
include "mlir/Interfaces/SideEffectInterfaces.td"

‎mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@
1010
#define MLIR_DIALECT_MEMREF_TRANSFORMOPS_MEMREFTRANSFORMOPS_H
1111

1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
13-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
13+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1414
#include "mlir/IR/OpImplementation.h"
1515

1616
namespace mlir {
1717
namespace memref {
1818
class AllocOp;
1919
} // namespace memref
20+
namespace transform {
21+
class OperationType;
22+
} // namespace transform
2023
} // namespace mlir
2124

2225
#define GET_OP_CLASSES

‎mlir/include/mlir/Dialect/MemRef/TransformOps/MemRefTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define MEMREF_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1515
include "mlir/Interfaces/SideEffectInterfaces.td"
1616
include "mlir/IR/OpBase.td"

‎mlir/include/mlir/Dialect/NVGPU/TransformOps/NVGPUTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
#include "mlir/Dialect/Transform/IR/TransformAttrs.h"
1313
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
14-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
14+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1515
#include "mlir/IR/OpImplementation.h"
1616
#include "mlir/IR/RegionKindInterface.h"
1717

‎mlir/include/mlir/Dialect/NVGPU/TransformOps/NVGPUTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
include "mlir/Dialect/Transform/IR/TransformAttrs.td"
1313
include "mlir/Dialect/Transform/IR/TransformDialect.td"
14-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
14+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1515
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1616
include "mlir/Interfaces/SideEffectInterfaces.td"
1717

‎mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#define MLIR_DIALECT_SCF_TRANSFORMOPS_SCFTRANSFORMOPS_H
1111

1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
13-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1413
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
14+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1515
#include "mlir/IR/OpImplementation.h"
1616
#include "mlir/Interfaces/LoopLikeInterface.h"
1717

‎mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define SCF_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1515
include "mlir/Interfaces/SideEffectInterfaces.td"
1616
include "mlir/IR/OpBase.td"

‎mlir/include/mlir/Dialect/SparseTensor/TransformOps/SparseTensorTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "mlir/Dialect/Transform/IR/MatchInterfaces.h"
1313
#include "mlir/Dialect/Transform/IR/TransformAttrs.h"
1414
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
15-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
15+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1616
#include "mlir/IR/OpImplementation.h"
1717
#include "mlir/IR/RegionKindInterface.h"
1818

‎mlir/include/mlir/Dialect/Tensor/TransformOps/TensorTransformOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
#ifndef MLIR_DIALECT_TENSOR_TRANSFORMOPS_TENSORTRANSFORMOPS_H
1010
#define MLIR_DIALECT_TENSOR_TRANSFORMOPS_TENSORTRANSFORMOPS_H
1111

12-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
1312
#include "mlir/Dialect/Transform/IR/TransformTypes.h"
13+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1414
#include "mlir/IR/OpImplementation.h"
1515
#include "mlir/IR/PatternMatch.h"
1616

‎mlir/include/mlir/Dialect/Tensor/TransformOps/TensorTransformOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define TENSOR_TRANSFORM_OPS
1111

1212
include "mlir/Dialect/Transform/IR/TransformDialect.td"
13-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
13+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1414
include "mlir/Dialect/Transform/IR/TransformTypes.td"
1515
include "mlir/Interfaces/SideEffectInterfaces.td"
1616
include "mlir/IR/OpBase.td"

‎mlir/include/mlir/Dialect/Transform/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
add_subdirectory(DebugExtension)
2+
add_subdirectory(Interfaces)
23
add_subdirectory(IR)
34
add_subdirectory(LoopExtension)
45
add_subdirectory(PDLExtension)

‎mlir/include/mlir/Dialect/Transform/DebugExtension/DebugExtensionOps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "mlir/Bytecode/BytecodeOpInterface.h"
1313
#include "mlir/Dialect/Transform/IR/MatchInterfaces.h"
1414
#include "mlir/Dialect/Transform/IR/TransformDialect.h"
15-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
15+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1616
#include "mlir/IR/OpDefinition.h"
1717
#include "mlir/IR/OpImplementation.h"
1818
#include "mlir/Interfaces/SideEffectInterfaces.h"

‎mlir/include/mlir/Dialect/Transform/DebugExtension/DebugExtensionOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
include "mlir/Interfaces/SideEffectInterfaces.td"
1818
include "mlir/IR/OpBase.td"
1919
include "mlir/Dialect/Transform/IR/MatchInterfaces.td"
20-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
20+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
2121
include "mlir/Dialect/Transform/IR/TransformDialect.td"
2222

2323
def DebugEmitRemarkAtOp : TransformDialectOp<"debug.emit_remark_at",

‎mlir/include/mlir/Dialect/Transform/IR/CMakeLists.txt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,7 @@ add_dependencies(mlir-headers MLIRTransformDialectEnumIncGen)
2424
add_mlir_dialect(TransformOps transform)
2525
add_mlir_doc(TransformOps TransformOps Dialects/ -gen-op-doc -dialect=transform)
2626

27-
# Contrary to what the name claims, this only produces the _op_ interface.
28-
add_mlir_interface(TransformInterfaces)
29-
add_mlir_doc(TransformInterfaces TransformOpInterfaces Dialects/ -gen-op-interface-docs)
30-
3127
add_mlir_interface(MatchInterfaces)
3228
add_dependencies(MLIRMatchInterfacesIncGen MLIRTransformInterfacesIncGen)
3329
add_mlir_doc(TransformInterfaces MatchOpInterfaces Dialects/ -gen-op-interface-docs)
3430

35-
set(LLVM_TARGET_DEFINITIONS TransformInterfaces.td)
36-
mlir_tablegen(TransformTypeInterfaces.h.inc -gen-type-interface-decls)
37-
mlir_tablegen(TransformTypeInterfaces.cpp.inc -gen-type-interface-defs)
38-
add_public_tablegen_target(MLIRTransformDialectTypeInterfacesIncGen)
39-
add_dependencies(mlir-headers MLIRTransformDialectTypeInterfacesIncGen)
40-
add_mlir_doc(TransformInterfaces TransformTypeInterfaces Dialects/ -gen-type-interface-docs)

‎mlir/include/mlir/Dialect/Transform/IR/MatchInterfaces.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include <optional>
1313
#include <type_traits>
1414

15-
#include "mlir/Dialect/Transform/IR/TransformInterfaces.h"
15+
#include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.h"
1616
#include "mlir/IR/OpDefinition.h"
1717
#include "llvm/ADT/STLExtras.h"
1818

‎mlir/include/mlir/Dialect/Transform/IR/MatchInterfaces.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88

99
include "mlir/IR/OpBase.td"
10-
include "mlir/Dialect/Transform/IR/TransformInterfaces.td"
10+
include "mlir/Dialect/Transform/Interfaces/TransformInterfaces.td"
1111

1212
def MatchOpInterface
1313
: OpInterface<"MatchOpInterface", [TransformOpInterface]> {

0 commit comments

Comments
 (0)