Skip to content

Commit 5ab65a6

Browse files
RKSimonRKSimon
committed
[X86] VPERM2*128 instructions aren't microcoded on znver2
This appears to be a copy+paste error from znver1 (which isn't really microcoded either - but it is rather complex!). Confirmed with Agner + uops.info.
1 parent cd60d10 commit 5ab65a6

File tree

3 files changed

+22
-13
lines changed

3 files changed

+22
-13
lines changed

‎llvm/lib/Target/X86/X86ScheduleZnver2.td

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -994,9 +994,18 @@ def : InstRW<[Zn2WritePCMPGTQYm], (instrs VPCMPGTQYrm)>;
994994
//-- Move instructions --//
995995

996996
// VPERM2F128 / VPERM2I128.
997-
def : InstRW<[WriteMicrocoded], (instrs VPERM2F128rr,
997+
def Zn2WriteVPERM2r : SchedWriteRes<[Zn2FPU2]> {
998+
let NumMicroOps = 1;
999+
let Latency = 3;
1000+
}
1001+
def : InstRW<[Zn2WriteVPERM2r], (instrs VPERM2F128rr,
9981002
VPERM2I128rr)>;
999-
def : InstRW<[WriteMicrocoded], (instrs VPERM2F128rm,
1003+
1004+
def Zn2WriteVPERM2m : SchedWriteRes<[Zn2AGU, Zn2FPU2]> {
1005+
let NumMicroOps = 1;
1006+
let Latency = 8;
1007+
}
1008+
def : InstRW<[Zn2WriteVPERM2m], (instrs VPERM2F128rm,
10001009
VPERM2I128rm)>;
10011010

10021011
def Zn2WriteBROADCAST : SchedWriteRes<[Zn2AGU, Zn2FPU13]> {
@@ -1011,7 +1020,7 @@ def : InstRW<[Zn2WriteBROADCAST], (instrs VBROADCASTF128rm,
10111020
// r32,x,i.
10121021
def Zn2WriteEXTRACTPSr : SchedWriteRes<[Zn2FPU12, Zn2FPU2]> {
10131022
let Latency = 2;
1014-
let NumMicroOps = 2;
1023+
let NumMicroOps = 2;
10151024
let ReleaseAtCycles = [1, 2];
10161025
}
10171026
def : InstRW<[Zn2WriteEXTRACTPSr], (instregex "(V?)EXTRACTPSrr")>;

‎llvm/test/tools/llvm-mca/X86/Znver2/resources-avx1.s

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,8 +1429,8 @@ vzeroupper
14291429
# CHECK-NEXT: 1 100 0.25 * vpcmpistri $1, (%rax), %xmm2
14301430
# CHECK-NEXT: 1 100 0.25 vpcmpistrm $1, %xmm0, %xmm2
14311431
# CHECK-NEXT: 1 100 0.25 * vpcmpistrm $1, (%rax), %xmm2
1432-
# CHECK-NEXT: 1 100 0.25 vperm2f128 $1, %ymm0, %ymm1, %ymm2
1433-
# CHECK-NEXT: 1 100 0.25 * vperm2f128 $1, (%rax), %ymm1, %ymm2
1432+
# CHECK-NEXT: 1 3 1.00 vperm2f128 $1, %ymm0, %ymm1, %ymm2
1433+
# CHECK-NEXT: 1 8 1.00 * vperm2f128 $1, (%rax), %ymm1, %ymm2
14341434
# CHECK-NEXT: 1 1 0.50 vpermilpd $1, %xmm0, %xmm2
14351435
# CHECK-NEXT: 1 8 0.50 * vpermilpd $1, (%rax), %xmm2
14361436
# CHECK-NEXT: 1 3 0.50 vpermilpd %xmm0, %xmm1, %xmm2
@@ -1739,7 +1739,7 @@ vzeroupper
17391739

17401740
# CHECK: Resource pressure per iteration:
17411741
# CHECK-NEXT: [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
1742-
# CHECK-NEXT: 117.00 117.00 117.00 0.25 0.25 0.25 0.25 - 126.58 192.58 196.75 305.08 -
1742+
# CHECK-NEXT: 117.33 117.33 117.33 0.25 0.25 0.25 0.25 - 126.58 192.58 198.75 305.08 -
17431743

17441744
# CHECK: Resource pressure by instruction:
17451745
# CHECK-NEXT: [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] Instructions:
@@ -2142,8 +2142,8 @@ vzeroupper
21422142
# CHECK-NEXT: - - - - - - - - - - - - - vpcmpistri $1, (%rax), %xmm2
21432143
# CHECK-NEXT: - - - - - - - - - - - - - vpcmpistrm $1, %xmm0, %xmm2
21442144
# CHECK-NEXT: - - - - - - - - - - - - - vpcmpistrm $1, (%rax), %xmm2
2145-
# CHECK-NEXT: - - - - - - - - - - - - - vperm2f128 $1, %ymm0, %ymm1, %ymm2
2146-
# CHECK-NEXT: - - - - - - - - - - - - - vperm2f128 $1, (%rax), %ymm1, %ymm2
2145+
# CHECK-NEXT: - - - - - - - - - - 1.00 - - vperm2f128 $1, %ymm0, %ymm1, %ymm2
2146+
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - - - 1.00 - - vperm2f128 $1, (%rax), %ymm1, %ymm2
21472147
# CHECK-NEXT: - - - - - - - - - 0.50 0.50 - - vpermilpd $1, %xmm0, %xmm2
21482148
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - - 0.50 0.50 - - vpermilpd $1, (%rax), %xmm2
21492149
# CHECK-NEXT: - - - - - - - - - 0.50 0.50 - - vpermilpd %xmm0, %xmm1, %xmm2

‎llvm/test/tools/llvm-mca/X86/Znver2/resources-avx2.s

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,8 @@ vpxor (%rax), %ymm1, %ymm2
558558
# CHECK-NEXT: 1 8 0.50 * vpcmpgtq (%rax), %ymm1, %ymm2
559559
# CHECK-NEXT: 1 1 0.33 vpcmpgtw %ymm0, %ymm1, %ymm2
560560
# CHECK-NEXT: 1 8 0.33 * vpcmpgtw (%rax), %ymm1, %ymm2
561-
# CHECK-NEXT: 1 100 0.25 vperm2i128 $1, %ymm0, %ymm1, %ymm2
562-
# CHECK-NEXT: 1 100 0.25 * vperm2i128 $1, (%rax), %ymm1, %ymm2
561+
# CHECK-NEXT: 1 3 1.00 vperm2i128 $1, %ymm0, %ymm1, %ymm2
562+
# CHECK-NEXT: 1 8 1.00 * vperm2i128 $1, (%rax), %ymm1, %ymm2
563563
# CHECK-NEXT: 1 2 0.50 vpermd %ymm0, %ymm1, %ymm2
564564
# CHECK-NEXT: 1 9 0.50 * vpermd (%rax), %ymm1, %ymm2
565565
# CHECK-NEXT: 1 2 0.50 vpermpd $1, %ymm0, %ymm2
@@ -779,7 +779,7 @@ vpxor (%rax), %ymm1, %ymm2
779779

780780
# CHECK: Resource pressure per iteration:
781781
# CHECK-NEXT: [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
782-
# CHECK-NEXT: 44.33 44.33 44.33 - - - - - 63.17 125.67 71.00 34.17 -
782+
# CHECK-NEXT: 44.67 44.67 44.67 - - - - - 63.17 125.67 73.00 34.17 -
783783

784784
# CHECK: Resource pressure by instruction:
785785
# CHECK-NEXT: [0] [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] Instructions:
@@ -881,8 +881,8 @@ vpxor (%rax), %ymm1, %ymm2
881881
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - 0.50 - - 0.50 - vpcmpgtq (%rax), %ymm1, %ymm2
882882
# CHECK-NEXT: - - - - - - - - 0.33 0.33 - 0.33 - vpcmpgtw %ymm0, %ymm1, %ymm2
883883
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - 0.33 0.33 - 0.33 - vpcmpgtw (%rax), %ymm1, %ymm2
884-
# CHECK-NEXT: - - - - - - - - - - - - - vperm2i128 $1, %ymm0, %ymm1, %ymm2
885-
# CHECK-NEXT: - - - - - - - - - - - - - vperm2i128 $1, (%rax), %ymm1, %ymm2
884+
# CHECK-NEXT: - - - - - - - - - - 1.00 - - vperm2i128 $1, %ymm0, %ymm1, %ymm2
885+
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - - - 1.00 - - vperm2i128 $1, (%rax), %ymm1, %ymm2
886886
# CHECK-NEXT: - - - - - - - - - 0.50 0.50 - - vpermd %ymm0, %ymm1, %ymm2
887887
# CHECK-NEXT: 0.33 0.33 0.33 - - - - - - 0.50 0.50 - - vpermd (%rax), %ymm1, %ymm2
888888
# CHECK-NEXT: - - - - - - - - - 0.50 0.50 - - vpermpd $1, %ymm0, %ymm2

0 commit comments

Comments
 (0)