Skip to content

Commit 5adbce0

Browse files
committed
[llvm][GitHub] Fix formatting of new contributor comments
GitHub won't reflow the text unless we put it all on one line. If we try to make our own paragrpahs it comes out too narrow or too wide.
1 parent 522c253 commit 5adbce0

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

llvm/utils/git/github-automation.py

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -226,18 +226,13 @@ def run(self) -> bool:
226226
{PRGreeter.COMMENT_TAG}
227227
Thank you for submitting a Pull Request (PR) to the LLVM Project!
228228
229-
This PR will be automatically labeled and the relevant teams will be
230-
notified.
229+
This PR will be automatically labeled and the relevant teams will be notified.
231230
232231
If you wish to, you can add reviewers by using the "Reviewers" section on this page.
233232
234-
If this is not working for you, it is probably because you do not have write
235-
permissions for the repository. In which case you can instead tag reviewers by
236-
name in a comment by using `@` followed by their GitHub username.
233+
If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username.
237234
238-
If you have received no comments on your PR for a week, you can request a review
239-
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
240-
is once a week. Please remember that you are asking for valuable time from other developers.
235+
If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.
241236
242237
If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html).
243238
@@ -281,18 +276,13 @@ def run(self) -> bool:
281276
{PRBuildbotInformation.COMMENT_TAG}
282277
@{self.author} Congratulations on having your first Pull Request (PR) merged into the LLVM Project!
283278
284-
Your changes will be combined with recent changes from other authors, then tested
285-
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, you may receive a report in an email or a comment on this PR.
279+
Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, you may receive a report in an email or a comment on this PR.
286280
287-
Please check whether problems have been caused by your change specifically, as
288-
the builds can include changes from many authors. It is not uncommon for your
289-
change to be included in a build that fails due to someone else's changes, or
290-
infrastructure issues.
281+
Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.
291282
292283
How to do this, and the rest of the post-merge process, is covered in detail [here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr).
293284
294-
If your change does cause a problem, it may be reverted, or you can revert it yourself.
295-
This is a normal part of [LLVM development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy). You can fix your changes and open a new PR to merge them again.
285+
If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of [LLVM development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy). You can fix your changes and open a new PR to merge them again.
296286
297287
If you don't get any reports, no action is required from you. Your changes are working as expected, well done!
298288
"""

0 commit comments

Comments
 (0)