Skip to content

Commit 5b6da6c

Browse files
committed
Cleanup unsured references, and remove incorrect comment
1 parent d70784c commit 5b6da6c

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

lldb/source/Plugins/Process/minidump/MinidumpParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ MinidumpParser::GetExceptionStreams() {
425425

426426
LLDB_LOG_ERROR(GetLog(LLDBLog::Process), ExpectedStream.takeError(),
427427
"Failed to read minidump exception stream: {0}");
428-
// return empty on failure.
428+
429429
return std::nullopt;
430430
}
431431

lldb/unittests/Process/minidump/MinidumpParserTest.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,7 @@ TEST_F(MinidumpParserTest, GetExceptionStream) {
253253
SetUpData("linux-x86_64.dmp");
254254
std::optional<std::vector<const minidump::ExceptionStream *>>
255255
exception_stream = parser->GetExceptionStreams();
256-
// LLVM::Expected has an explicit bool operator that determines if
257-
// the expected value is an error or not.
258-
ASSERT_TRUE((bool)exception_stream);
256+
ASSERT_TRUE(exception_stream);
259257
ASSERT_EQ(1UL, exception_stream->size());
260258
ASSERT_EQ(11UL, exception_stream->at(0)->ThreadId);
261259
}

llvm/lib/Object/Minidump.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "llvm/Object/Minidump.h"
1010
#include "llvm/Object/Error.h"
1111
#include "llvm/Support/ConvertUTF.h"
12-
#include <iostream>
1312

1413
using namespace llvm;
1514
using namespace llvm::object;

0 commit comments

Comments
 (0)