Skip to content

Commit 5bbcc76

Browse files
authored
[SLP][REVEC] getNumElements should not be used as VF when REVEC is enabled. (#134031)
1 parent a13a51b commit 5bbcc76

File tree

2 files changed

+72
-2
lines changed

2 files changed

+72
-2
lines changed

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11329,8 +11329,7 @@ class BoUpSLP::ShuffleCostEstimator : public BaseShuffleAnalysis {
1132911329
if (!E2 && InVectors.size() == 1) {
1133011330
unsigned VF = E1.getVectorFactor();
1133111331
if (Value *V1 = dyn_cast<Value *>(InVectors.front())) {
11332-
VF = std::max(VF,
11333-
cast<FixedVectorType>(V1->getType())->getNumElements());
11332+
VF = std::max(VF, getVF(V1));
1133411333
} else {
1133511334
const auto *E = cast<const TreeEntry *>(InVectors.front());
1133611335
VF = std::max(VF, E->getVectorFactor());
Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -mtriple=x86_64-unknown-linux-gnu -mattr=+avx2 -passes=slp-vectorizer -S -slp-revec < %s | FileCheck %s
3+
4+
define i32 @test1(<4 x float> %0, <4 x float> %1) {
5+
; CHECK-LABEL: @test1(
6+
; CHECK-NEXT: entry:
7+
; CHECK-NEXT: [[TMP2:%.*]] = getelementptr i8, ptr null, i64 288
8+
; CHECK-NEXT: [[TMP3:%.*]] = getelementptr i8, ptr null, i64 304
9+
; CHECK-NEXT: [[TMP4:%.*]] = getelementptr i8, ptr null, i64 416
10+
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr i8, ptr null, i64 432
11+
; CHECK-NEXT: [[TMP6:%.*]] = getelementptr i8, ptr null, i64 256
12+
; CHECK-NEXT: [[TMP7:%.*]] = getelementptr i8, ptr null, i64 272
13+
; CHECK-NEXT: [[TMP8:%.*]] = getelementptr i8, ptr null, i64 288
14+
; CHECK-NEXT: [[TMP9:%.*]] = getelementptr i8, ptr null, i64 304
15+
; CHECK-NEXT: [[TMP10:%.*]] = load <4 x float>, ptr [[TMP2]], align 16
16+
; CHECK-NEXT: [[TMP11:%.*]] = load <4 x float>, ptr [[TMP3]], align 16
17+
; CHECK-NEXT: [[TMP12:%.*]] = load <4 x float>, ptr [[TMP4]], align 16
18+
; CHECK-NEXT: [[TMP13:%.*]] = load <4 x float>, ptr [[TMP5]], align 16
19+
; CHECK-NEXT: [[TMP14:%.*]] = fmul <4 x float> [[TMP10]], [[TMP0:%.*]]
20+
; CHECK-NEXT: [[TMP15:%.*]] = fmul <4 x float> [[TMP11]], [[TMP0]]
21+
; CHECK-NEXT: [[TMP16:%.*]] = fmul <4 x float> [[TMP12]], [[TMP0]]
22+
; CHECK-NEXT: [[TMP17:%.*]] = fmul <4 x float> [[TMP13]], [[TMP0]]
23+
; CHECK-NEXT: [[TMP18:%.*]] = fsub <4 x float> [[TMP14]], [[TMP1:%.*]]
24+
; CHECK-NEXT: [[TMP19:%.*]] = fsub <4 x float> [[TMP15]], zeroinitializer
25+
; CHECK-NEXT: [[TMP20:%.*]] = fsub <4 x float> [[TMP16]], [[TMP1]]
26+
; CHECK-NEXT: [[TMP21:%.*]] = fsub <4 x float> [[TMP17]], zeroinitializer
27+
; CHECK-NEXT: [[TMP22:%.*]] = fmul <4 x float> [[TMP11]], zeroinitializer
28+
; CHECK-NEXT: [[TMP23:%.*]] = fmul <4 x float> [[TMP13]], zeroinitializer
29+
; CHECK-NEXT: [[TMP24:%.*]] = fadd <4 x float> [[TMP18]], [[TMP0]]
30+
; CHECK-NEXT: [[TMP25:%.*]] = fadd <4 x float> [[TMP19]], zeroinitializer
31+
; CHECK-NEXT: [[TMP26:%.*]] = fadd <4 x float> [[TMP20]], [[TMP0]]
32+
; CHECK-NEXT: [[TMP27:%.*]] = fadd <4 x float> [[TMP21]], zeroinitializer
33+
; CHECK-NEXT: store <4 x float> [[TMP24]], ptr [[TMP6]], align 16
34+
; CHECK-NEXT: store <4 x float> [[TMP25]], ptr [[TMP7]], align 16
35+
; CHECK-NEXT: store <4 x float> [[TMP26]], ptr [[TMP8]], align 16
36+
; CHECK-NEXT: store <4 x float> [[TMP27]], ptr [[TMP9]], align 16
37+
; CHECK-NEXT: ret i32 0
38+
;
39+
entry:
40+
%2 = getelementptr i8, ptr null, i64 288
41+
%3 = getelementptr i8, ptr null, i64 304
42+
%4 = getelementptr i8, ptr null, i64 416
43+
%5 = getelementptr i8, ptr null, i64 432
44+
%6 = getelementptr i8, ptr null, i64 256
45+
%7 = getelementptr i8, ptr null, i64 272
46+
%8 = getelementptr i8, ptr null, i64 288
47+
%9 = getelementptr i8, ptr null, i64 304
48+
%10 = load <4 x float>, ptr %2, align 16
49+
%11 = load <4 x float>, ptr %3, align 16
50+
%12 = load <4 x float>, ptr %4, align 16
51+
%13 = load <4 x float>, ptr %5, align 16
52+
%14 = fmul <4 x float> %10, %0
53+
%15 = fmul <4 x float> %11, %0
54+
%16 = fmul <4 x float> %12, %0
55+
%17 = fmul <4 x float> %13, %0
56+
%18 = fsub <4 x float> %14, %1
57+
%19 = fsub <4 x float> %15, zeroinitializer
58+
%20 = fsub <4 x float> %16, %1
59+
%21 = fsub <4 x float> %17, zeroinitializer
60+
%22 = fmul <4 x float> %11, zeroinitializer
61+
%23 = fmul <4 x float> %13, zeroinitializer
62+
%24 = fadd <4 x float> %18, %0
63+
%25 = fadd <4 x float> %19, zeroinitializer
64+
%26 = fadd <4 x float> %20, %0
65+
%27 = fadd <4 x float> %21, zeroinitializer
66+
store <4 x float> %24, ptr %6, align 16
67+
store <4 x float> %25, ptr %7, align 16
68+
store <4 x float> %26, ptr %8, align 16
69+
store <4 x float> %27, ptr %9, align 16
70+
ret i32 0
71+
}

0 commit comments

Comments
 (0)