[X86] Add necessary check isReg() when updating LiveVariables in convertToThreeAddress

yubingex007-a11y · yubingex007-a11y · commit 5bc36c8cb483 · 2022-11-10T21:12:00.000+08:00
Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D137388
diff --git a/llvm/lib/Target/X86/X86InstrInfo.cpp b/llvm/lib/Target/X86/X86InstrInfo.cpp
@@ -1768,7 +1768,7 @@ MachineInstr *X86InstrInfo::convertToThreeAddress(MachineInstr &MI,
   if (LV) {  // Update live variables
     for (unsigned I = 0; I < NumRegOperands; ++I) {
       MachineOperand &Op = MI.getOperand(I);
-      if (Op.isDead() || Op.isKill())
+      if (Op.isReg() && (Op.isDead() || Op.isKill()))
         LV->replaceKillInstruction(Op.getReg(), MI, *NewMI);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1768,7 +1768,7 @@ MachineInstr *X86InstrInfo::convertToThreeAddress(MachineInstr &MI,`
`1768`	`1768`	`if (LV) { // Update live variables`
`1769`	`1769`	`for (unsigned I = 0; I < NumRegOperands; ++I) {`
`1770`	`1770`	`MachineOperand &Op = MI.getOperand(I);`
`1771`		`- if (Op.isDead() \|\| Op.isKill())`
	`1771`	`+ if (Op.isReg() && (Op.isDead() \|\| Op.isKill()))`
`1772`	`1772`	`LV->replaceKillInstruction(Op.getReg(), MI, *NewMI);`
`1773`	`1773`	`}`
`1774`	`1774`	`}`