Fixup: delete tests and address nits

Author: Michael Levesque-Dion

mlir/test/mlir-tblgen/dialect-with-dependents.td

@@ -285,8 +285,9 @@ static void emitDialectDef(Dialect &dialect, raw_ostream &os) {
     llvm::raw_string_ostream dialectsOs(dependentDialectRegistrations);
     llvm::interleave(
         dialect.getDependentDialects(), dialectsOs,
-        [&dialectsOs](StringRef dd) {
-          dialectsOs << llvm::formatv(dialectRegistrationTemplate, dd);
+        [&](StringRef dependentDialect) {
+          dialectsOs << llvm::formatv(dialectRegistrationTemplate,
+                                      dependentDialect);
         },
         "\n  ");
   }

mlir/test/mlir-tblgen/pass.td

@@ -308,8 +308,9 @@ static void emitPassDefs(const Pass &pass, raw_ostream &os) {
     llvm::raw_string_ostream dialectsOs(dependentDialectRegistrations);
     llvm::interleave(
         pass.getDependentDialects(), dialectsOs,
-        [&dialectsOs](StringRef dd) {
-          dialectsOs << llvm::formatv(dialectRegistrationTemplate, dd);
+        [&](StringRef dependentDialect) {
+          dialectsOs << llvm::formatv(dialectRegistrationTemplate,
+                                      dependentDialect);
         },
         "\n    ");
   }
@@ -426,8 +427,9 @@ static void emitOldPassDecl(const Pass &pass, raw_ostream &os) {
     llvm::raw_string_ostream dialectsOs(dependentDialectRegistrations);
     llvm::interleave(
         pass.getDependentDialects(), dialectsOs,
-        [&dialectsOs](StringRef dd) {
-          dialectsOs << llvm::formatv(dialectRegistrationTemplate, dd);
+        [&](StringRef dependentDialect) {
+          dialectsOs << llvm::formatv(dialectRegistrationTemplate,
+                                      dependentDialect);
         },
         "\n    ");
   }