Fix issue found by @ftynse. Also make init function private.

Author: ingomueller-net

mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td

@@ -78,9 +78,6 @@ def Transform_Dialect : Dialect {
     using ExtensionTypePrintingHook =
         std::function<void(::mlir::Type, ::mlir::AsmPrinter &)>;
 
-    /// Loads the given module into the transform symbol library module.
-    void initializeLibraryModule();
-
     /// Loads the given module into the transform symbol library module.
     LogicalResult loadIntoLibraryModule(::mlir::OwningOpRef<::mlir::ModuleOp> &&
                                         library);
@@ -94,6 +91,10 @@ def Transform_Dialect : Dialect {
     }
 
   private:
+    /// Initializes the transform symbol library module. Must be called from
+    /// `TransformDialect::initialize` for the library module to work.
+    void initializeLibraryModule();
+
     /// Registers operations specified as template parameters with this
     /// dialect. Checks that they implement the required interfaces.
     template <typename... OpTys>

mlir/lib/Dialect/Transform/IR/TransformDialect.cpp

@@ -91,6 +91,11 @@ void transform::TransformDialect::printType(Type type,
   it->getSecond()(type, printer);
 }
 
+LogicalResult transform::TransformDialect::loadIntoLibraryModule(
+    ::mlir::OwningOpRef<::mlir::ModuleOp> &&library) {
+  return detail::mergeSymbolsInto(getLibraryModule(), std::move(library));
+}
+
 void transform::TransformDialect::initializeLibraryModule() {
   MLIRContext *context = getContext();
   auto loc =
@@ -100,11 +105,6 @@ void transform::TransformDialect::initializeLibraryModule() {
                                UnitAttr::get(context));
 }
 
-LogicalResult transform::TransformDialect::loadIntoLibraryModule(
-    ::mlir::OwningOpRef<::mlir::ModuleOp> &&library) {
-  return detail::mergeSymbolsInto(getLibraryModule(), std::move(library));
-}
-
 void transform::TransformDialect::reportDuplicateTypeRegistration(
     StringRef mnemonic) {
   std::string buffer;