Skip to content

Commit 5cc1f06

Browse files
author
Kevin Frei
committed
Added CURL dependency to lit configuration 'stuff'
1 parent 8be295e commit 5cc1f06

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

lldb/test/API/debuginfod/Normal/TestDebuginfod.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ class DebugInfodTests(TestBase):
2323
# No need to try every flavor of debug inf.
2424
NO_DEBUG_INFO_TESTCASE = True
2525

26-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
26+
def setUp(self):
27+
TestBase.setUp(self)
28+
if "Debuginfod" not in configuration.enabled_plugins:
29+
self.skipTest("The Debuginfod SymbolLocator plugin is not enabled")
30+
31+
2732
def test_normal_no_symbols(self):
2833
"""
2934
Validate behavior with no symbols or symbol locator.
@@ -32,7 +37,6 @@ def test_normal_no_symbols(self):
3237
test_root = self.config_test(["a.out"])
3338
self.try_breakpoint(False)
3439

35-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
3640
def test_normal_default(self):
3741
"""
3842
Validate behavior with symbols, but no symbol locator.
@@ -41,7 +45,6 @@ def test_normal_default(self):
4145
test_root = self.config_test(["a.out", "a.out.debug"])
4246
self.try_breakpoint(True)
4347

44-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
4548
def test_debuginfod_symbols(self):
4649
"""
4750
Test behavior with the full binary available from Debuginfod as
@@ -50,7 +53,6 @@ def test_debuginfod_symbols(self):
5053
test_root = self.config_test(["a.out"], "a.out.unstripped")
5154
self.try_breakpoint(True)
5255

53-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
5456
def test_debuginfod_executable(self):
5557
"""
5658
Test behavior with the full binary available from Debuginfod as
@@ -59,7 +61,6 @@ def test_debuginfod_executable(self):
5961
test_root = self.config_test(["a.out"], None, "a.out.unstripped")
6062
self.try_breakpoint(True)
6163

62-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
6364
def test_debuginfod_okd_symbols(self):
6465
"""
6566
Test behavior with the 'only-keep-debug' symbols available from Debuginfod.

lldb/test/API/debuginfod/SplitDWARF/TestDebuginfodDWP.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,25 @@ class DebugInfodDWPTests(TestBase):
2626
# No need to try every flavor of debug inf.
2727
NO_DEBUG_INFO_TESTCASE = True
2828

29-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
29+
def setUp(self):
30+
TestBase.setUp(self)
31+
if "Debuginfod" not in configuration.enabled_plugins:
32+
self.skipTest("The Debuginfod SymbolLocator plugin is not enabled")
33+
3034
def test_normal_stripped(self):
3135
"""
3236
Validate behavior with a stripped binary, no symbols or symbol locator.
3337
"""
3438
self.config_test(["a.out"])
3539
self.try_breakpoint(False)
3640

37-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
3841
def test_normal_stripped_split_with_dwp(self):
3942
"""
4043
Validate behavior with symbols, but no symbol locator.
4144
"""
4245
self.config_test(["a.out", "a.out.debug", "a.out.dwp"])
4346
self.try_breakpoint(True)
4447

45-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
4648
def test_normal_stripped_only_dwp(self):
4749
"""
4850
Validate behavior *with* dwp symbols only, but missing other symbols,
@@ -52,15 +54,13 @@ def test_normal_stripped_only_dwp(self):
5254
self.config_test(["a.out", "a.out.dwp"])
5355
self.try_breakpoint(False)
5456

55-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
5657
def test_debuginfod_dwp_from_service(self):
5758
"""
5859
Test behavior with the unstripped binary, and DWP from the service.
5960
"""
6061
self.config_test(["a.out.debug"], "a.out.dwp")
6162
self.try_breakpoint(True)
6263

63-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
6464
def test_debuginfod_both_symfiles_from_service(self):
6565
"""
6666
Test behavior with a stripped binary, with the unstripped binary and
@@ -69,7 +69,6 @@ def test_debuginfod_both_symfiles_from_service(self):
6969
self.config_test(["a.out"], "a.out.dwp", "a.out.unstripped")
7070
self.try_breakpoint(True)
7171

72-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
7372
def test_debuginfod_both_okd_symfiles_from_service(self):
7473
"""
7574
Test behavior with both the only-keep-debug symbols and the dwp symbols

lldb/test/API/lit.site.cfg.py.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ lldb_build_intel_pt = '@LLDB_BUILD_INTEL_PT@'
4444
if lldb_build_intel_pt == '1':
4545
config.enabled_plugins.append('intel-pt')
4646

47+
llvm_enable_curl = '@LLVM_ENABLE_CURL@'
48+
if llvm_enable_curl == '1':
49+
config.enabled_plugins.append('Debuginfod')
50+
4751
# Additional dotest arguments can be passed to lit by providing a
4852
# semicolon-separates list: --param dotest-args="arg;arg".
4953
dotest_lit_args_str = lit_config.params.get('dotest-args', None)

lldb/test/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ endif()
238238
# These values are not canonicalized within LLVM.
239239
llvm_canonicalize_cmake_booleans(
240240
LLDB_BUILD_INTEL_PT
241+
LLVM_ENABLE_CURL
241242
LLDB_ENABLE_PYTHON
242243
LLDB_ENABLE_LUA
243244
LLDB_ENABLE_LZMA

0 commit comments

Comments
 (0)