simplify capture analysis

Author: usx95

clang/lib/Sema/CheckExprLifetime.cpp

@@ -1452,13 +1452,8 @@ checkExprLifetimeImpl(Sema &SemaRef, const InitializedEntity *InitEntity,
   }
   case LK_LifetimeCapture: {
     Path.push_back({IndirectLocalPathEntry::LifetimeCapture, Init});
-    if (isRecordWithAttr<PointerAttr>(Init->getType()))
-      HasReferenceBinding = false;
-    // Skip the top MTE if it is a temporary object of the pointer-like type
-    // itself.
-    if (auto *MTE = dyn_cast<MaterializeTemporaryExpr>(Init);
-        MTE && isPointerLikeType(Init->getType()))
-      Init = MTE->getSubExpr();
+    if (isPointerLikeType(Init->getType()))
+      Path.push_back({IndirectLocalPathEntry::GslPointerInit, Init});
     break;
   }
   default:

clang/test/Sema/warn-lifetime-analysis-capture-by.cpp

@@ -309,13 +309,9 @@ void use_with_optional_view() {
   vector_of_view.push_back(optional_of_view.value());
   vector_of_view.push_back(getOptionalS().value()); // expected-warning {{captured}}
 
-  // FIXME: Following 2 cases are false positives:
-  vector_of_view.push_back(getOptionalSV().value()); // expected-warning {{captured}}
-  vector_of_view.push_back(getOptionalMySV().value());  // expected-warning {{captured}}
-
-  // (maybe) FIXME: We may choose to diagnose the following case.
-  // This happens because 'MyStringViewNotPointer' is not marked as a [[gsl::Pointer]] but is derived from one.
-  vector_of_view.push_back(getOptionalMySVNotP().value()); // expected-warning {{captured}}
+  vector_of_view.push_back(getOptionalSV().value());
+  vector_of_view.push_back(getOptionalMySV().value());
+  vector_of_view.push_back(getOptionalMySVNotP().value());
 }
 } // namespace conatiners_with_different