Skip to content

Commit 5ed6792

Browse files
author
Evan Cheng
committed
Add comments for missed opportunities.
llvm-svn: 100610
1 parent fcbcc0b commit 5ed6792

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

llvm/lib/CodeGen/MachineLICM.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
247247
if (!CurLoop->contains(BB))
248248
continue;
249249
// Conservatively treat live-in's as an external def.
250+
// FIXME: That means a reload that's reused into a fallthrough block
251+
// will not be LICM'ed.
250252
for (MachineBasicBlock::const_livein_iterator I = BB->livein_begin(),
251253
E = BB->livein_end(); I != E; ++I) {
252254
unsigned Reg = *I;
@@ -282,7 +284,8 @@ void MachineLICM::HoistRegionPostRA(MachineDomTreeNode *N) {
282284
}
283285
}
284286

285-
// FIXME: Only consider reloads for now.
287+
// FIXME: Only consider reloads for now. We should be able to handle
288+
// remat which does not have register operands.
286289
bool SkipCheck = false;
287290
int FI;
288291
if (SeenDef && !RuledOut) {

0 commit comments

Comments
 (0)