ValueMapper does not preserve inline assembly dialect when remapping the type

topperc · topperc · commit 5f65faef2c61 · 2020-05-17T14:57:50.000-07:00
Bug report: https://bugs.llvm.org/show_bug.cgi?id=45291 Patch by Tomasz Miąsko Differential Revision: https://reviews.llvm.org/D80066
diff --git a/llvm/lib/Transforms/Utils/ValueMapper.cpp b/llvm/lib/Transforms/Utils/ValueMapper.cpp
@@ -368,7 +368,8 @@ Value *Mapper::mapValue(const Value *V) {
 
       if (NewTy != IA->getFunctionType())
         V = InlineAsm::get(NewTy, IA->getAsmString(), IA->getConstraintString(),
-                           IA->hasSideEffects(), IA->isAlignStack());
+                           IA->hasSideEffects(), IA->isAlignStack(),
+                           IA->getDialect());
     }
 
     return getVM()[V] = const_cast<Value *>(V);

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,8 @@ Value Mapper::mapValue(const Value V) {`
`368`	`368`
`369`	`369`	`if (NewTy != IA->getFunctionType())`
`370`	`370`	`V = InlineAsm::get(NewTy, IA->getAsmString(), IA->getConstraintString(),`
`371`		`- IA->hasSideEffects(), IA->isAlignStack());`
	`371`	`+ IA->hasSideEffects(), IA->isAlignStack(),`
	`372`	`+ IA->getDialect());`
`372`	`373`	`}`
`373`	`374`
`374`	`375`	`return getVM()[V] = const_cast<Value *>(V);`