[clang][NFC] Update code style conventions

Author: Atousa

clang/docs/ReleaseNotes.rst

@@ -156,6 +156,9 @@ Improvements to Clang's diagnostics
 - The ``-Wshorten-64-to-32`` diagnostic is now grouped under ``-Wimplicit-int-conversion`` instead
    of ``-Wconversion``. Fixes `#69444 <https://github.com/llvm/llvm-project/issues/69444>`_.
 
+- Clang now uses thousand separators when printing large numbers in integer overflow diagnostics.
+  Fixes `#80939 <https://github.com/llvm/llvm-project/issues/80939>`_.
+  
 Improvements to Clang's time-trace
 ----------------------------------
 

llvm/include/llvm/ADT/APInt.h

@@ -1627,7 +1627,7 @@ class [[nodiscard]] APInt {
   /// digits.
   void toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
                 bool formatAsCLiteral = false, bool UpperCase = true,
-                bool insertSeparators = false) const;
+                bool InsertSeparators = false) const;
 
   /// Considers the APInt to be unsigned and converts it into a string in the
   /// radix given. The radix can be 2, 8, 10 16, or 36.

llvm/include/llvm/ADT/StringExtras.h

@@ -330,9 +330,9 @@ inline std::string itostr(int64_t X) {
 
 inline std::string toString(const APInt &I, unsigned Radix, bool Signed,
                             bool formatAsCLiteral = false,
-                            bool upperCase = true, bool addSeparators = false) {
+                            bool UpperCase = true, bool InsertSeparators = false) {
   SmallString<40> S;
-  I.toString(S, Radix, Signed, formatAsCLiteral, upperCase, addSeparators);
+  I.toString(S, Radix, Signed, formatAsCLiteral, UpperCase, InsertSeparators);
   return std::string(S);
 }
 

llvm/lib/Support/APInt.cpp

@@ -2162,7 +2162,7 @@ void APInt::fromString(unsigned numbits, StringRef str, uint8_t radix) {
 
 void APInt::toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
                      bool formatAsCLiteral, bool UpperCase,
-                     bool insertSeparators) const {
+                     bool InsertSeparators) const {
   assert((Radix == 10 || Radix == 8 || Radix == 16 || Radix == 2 ||
           Radix == 36) &&
          "Radix should be 2, 8, 10, 16, or 36!");
@@ -2229,9 +2229,8 @@ void APInt::toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
 
     int Pos = 0;
     while (N) {
-      if (insertSeparators && Pos % Grouping == 0 && Pos > 0) {
+      if (InsertSeparators && Pos % Grouping == 0 && Pos > 0) 
         *--BufPtr = '\'';
-      }
       *--BufPtr = Digits[N % Radix];
       N /= Radix;
       Pos++;
@@ -2269,9 +2268,9 @@ void APInt::toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
     int Pos = 0;
     while (Tmp.getBoolValue()) {
       unsigned Digit = unsigned(Tmp.getRawData()[0]) & MaskAmt;
-      if (insertSeparators && Pos % Grouping == 0 && Pos > 0) {
+      if (InsertSeparators && Pos % Grouping == 0 && Pos > 0) 
         Str.push_back('\'');
-      }
+
       Str.push_back(Digits[Digit]);
       Tmp.lshrInPlace(ShiftAmt);
       Pos++;
@@ -2282,9 +2281,9 @@ void APInt::toString(SmallVectorImpl<char> &Str, unsigned Radix, bool Signed,
       uint64_t Digit;
       udivrem(Tmp, Radix, Tmp, Digit);
       assert(Digit < Radix && "divide failed");
-      if (insertSeparators && Pos % Grouping == 0 && Pos > 0) {
+      if (InsertSeparators && Pos % Grouping == 0 && Pos > 0)
         Str.push_back('\'');
-      }
+
       Str.push_back(Digits[Digit]);
       Pos++;
     }