Apply clang-tidy fixes for performance-unnecessary-value-param in ConvertConv2DToImg2Col.cpp (NFC)

joker-eph · joker-eph · commit 60caa8ef74bf · 2024-01-18T16:39:20.000-08:00
diff --git a/mlir/lib/Dialect/Linalg/Transforms/ConvertConv2DToImg2Col.cpp b/mlir/lib/Dialect/Linalg/Transforms/ConvertConv2DToImg2Col.cpp
@@ -26,7 +26,7 @@ namespace mlir {
 namespace linalg {
 static bool hasAllOneValues(DenseIntElementsAttr attr) {
   return llvm::all_of(
-      attr, [](APInt element) { return element.getSExtValue() == 1; });
+      attr, [](const APInt &element) { return element.getSExtValue() == 1; });
 }
 
 static Value createAdd(Location loc, Value x, Value y, OpBuilder &builder) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ namespace mlir {`
`26`	`26`	`namespace linalg {`
`27`	`27`	`static bool hasAllOneValues(DenseIntElementsAttr attr) {`
`28`	`28`	`return llvm::all_of(`
`29`		`- attr, [](APInt element) { return element.getSExtValue() == 1; });`
	`29`	`+ attr, [](const APInt &element) { return element.getSExtValue() == 1; });`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`static Value createAdd(Location loc, Value x, Value y, OpBuilder &builder) {`