Skip to content

Commit 616a8ce

Browse files
authored
[clang-format] Correctly annotate braces in macro definition (#107352)
Also add a test case for #107096. Fixes #106418.
1 parent 16df489 commit 616a8ce

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

clang/lib/Format/UnwrappedLineParser.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,8 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) {
570570
NextTok->isOneOf(Keywords.kw_of, Keywords.kw_in,
571571
Keywords.kw_as));
572572
ProbablyBracedList =
573-
ProbablyBracedList || (IsCpp && NextTok->is(tok::l_paren));
573+
ProbablyBracedList || (IsCpp && (PrevTok->Tok.isLiteral() ||
574+
NextTok->is(tok::l_paren)));
574575

575576
// If there is a comma, semicolon or right paren after the closing
576577
// brace, we assume this is a braced initializer list.

clang/unittests/Format/TokenAnnotatorTest.cpp

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3278,6 +3278,26 @@ TEST_F(TokenAnnotatorTest, BraceKind) {
32783278
EXPECT_BRACE_KIND(Tokens[10], BK_Block);
32793279
EXPECT_TOKEN(Tokens[11], tok::r_brace, TT_StructRBrace);
32803280
EXPECT_BRACE_KIND(Tokens[11], BK_Block);
3281+
3282+
Tokens = annotate("#define MACRO \\\n"
3283+
" struct hash<type> { \\\n"
3284+
" void f() { return; } \\\n"
3285+
" };");
3286+
ASSERT_EQ(Tokens.size(), 20u) << Tokens;
3287+
EXPECT_TOKEN(Tokens[8], tok::l_brace, TT_StructLBrace);
3288+
EXPECT_BRACE_KIND(Tokens[8], BK_Block);
3289+
EXPECT_TOKEN(Tokens[10], tok::identifier, TT_FunctionDeclarationName);
3290+
EXPECT_TOKEN(Tokens[11], tok::l_paren, TT_FunctionDeclarationLParen);
3291+
EXPECT_TOKEN(Tokens[13], tok::l_brace, TT_FunctionLBrace);
3292+
EXPECT_BRACE_KIND(Tokens[13], BK_Block);
3293+
EXPECT_BRACE_KIND(Tokens[16], BK_Block);
3294+
EXPECT_TOKEN(Tokens[17], tok::r_brace, TT_StructRBrace);
3295+
EXPECT_BRACE_KIND(Tokens[17], BK_Block);
3296+
3297+
Tokens = annotate("#define MEMBER(NAME) NAME{\"\"}");
3298+
ASSERT_EQ(Tokens.size(), 11u) << Tokens;
3299+
EXPECT_BRACE_KIND(Tokens[7], BK_BracedInit);
3300+
EXPECT_BRACE_KIND(Tokens[9], BK_BracedInit);
32813301
}
32823302

32833303
TEST_F(TokenAnnotatorTest, UnderstandsElaboratedTypeSpecifier) {

0 commit comments

Comments
 (0)