Skip to content

Commit 61757fb

Browse files
committed
[DAG] Remove pointless peephole from refineUniformBase [nfc]
No need to special case add 0, N. SelectionDAG::getNode contains the canonicalization and simplification for this case, so no need to duplicate it here.
1 parent e9e1892 commit 61757fb

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11650,10 +11650,7 @@ bool refineUniformBase(SDValue &BasePtr, SDValue &Index, bool IndexIsScaled,
1165011650
if (SDValue SplatVal = DAG.getSplatValue(Index);
1165111651
SplatVal && !isNullConstant(SplatVal) &&
1165211652
SplatVal.getValueType() == VT) {
11653-
if (isNullConstant(BasePtr))
11654-
BasePtr = SplatVal;
11655-
else
11656-
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
11653+
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
1165711654
Index = DAG.getSplat(Index.getValueType(), DL, DAG.getConstant(0, DL, VT));
1165811655
return true;
1165911656
}
@@ -11663,19 +11660,13 @@ bool refineUniformBase(SDValue &BasePtr, SDValue &Index, bool IndexIsScaled,
1166311660

1166411661
if (SDValue SplatVal = DAG.getSplatValue(Index.getOperand(0));
1166511662
SplatVal && SplatVal.getValueType() == VT) {
11666-
if (isNullConstant(BasePtr))
11667-
BasePtr = SplatVal;
11668-
else
11669-
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
11663+
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
1167011664
Index = Index.getOperand(1);
1167111665
return true;
1167211666
}
1167311667
if (SDValue SplatVal = DAG.getSplatValue(Index.getOperand(1));
1167411668
SplatVal && SplatVal.getValueType() == VT) {
11675-
if (isNullConstant(BasePtr))
11676-
BasePtr = SplatVal;
11677-
else
11678-
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
11669+
BasePtr = DAG.getNode(ISD::ADD, DL, VT, BasePtr, SplatVal);
1167911670
Index = Index.getOperand(0);
1168011671
return true;
1168111672
}

0 commit comments

Comments
 (0)