Skip to content

Commit 6303563

Browse files
Simplify MS mangling of bultin types (NFC) (#125051)
Saves including 4 files, reduces the number of switch cases, less error prone when adding new types, at the "cost" of adding a` default:`.
1 parent b6e50ed commit 6303563

File tree

1 file changed

+2
-38
lines changed

1 file changed

+2
-38
lines changed

clang/lib/AST/MicrosoftMangle.cpp

Lines changed: 2 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2810,49 +2810,13 @@ void MicrosoftCXXNameMangler::mangleType(const BuiltinType *T, Qualifiers,
28102810
break;
28112811
#include "clang/Basic/HLSLIntangibleTypes.def"
28122812

2813-
#define SVE_TYPE(Name, Id, SingletonId) \
2814-
case BuiltinType::Id:
2815-
#define SVE_SCALAR_TYPE(Name, MangledName, Id, SingletonId, Bits)
2816-
#include "clang/Basic/AArch64SVEACLETypes.def"
2817-
#define PPC_VECTOR_TYPE(Name, Id, Size) \
2818-
case BuiltinType::Id:
2819-
#include "clang/Basic/PPCTypes.def"
2820-
#define RVV_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
2821-
#include "clang/Basic/RISCVVTypes.def"
2822-
#define AMDGPU_TYPE(Name, Id, SingletonId, Width, Align) case BuiltinType::Id:
2823-
#include "clang/Basic/AMDGPUTypes.def"
2824-
case BuiltinType::ShortAccum:
2825-
case BuiltinType::Accum:
2826-
case BuiltinType::LongAccum:
2827-
case BuiltinType::UShortAccum:
2828-
case BuiltinType::UAccum:
2829-
case BuiltinType::ULongAccum:
2830-
case BuiltinType::ShortFract:
2831-
case BuiltinType::Fract:
2832-
case BuiltinType::LongFract:
2833-
case BuiltinType::UShortFract:
2834-
case BuiltinType::UFract:
2835-
case BuiltinType::ULongFract:
2836-
case BuiltinType::SatShortAccum:
2837-
case BuiltinType::SatAccum:
2838-
case BuiltinType::SatLongAccum:
2839-
case BuiltinType::SatUShortAccum:
2840-
case BuiltinType::SatUAccum:
2841-
case BuiltinType::SatULongAccum:
2842-
case BuiltinType::SatShortFract:
2843-
case BuiltinType::SatFract:
2844-
case BuiltinType::SatLongFract:
2845-
case BuiltinType::SatUShortFract:
2846-
case BuiltinType::SatUFract:
2847-
case BuiltinType::SatULongFract:
2848-
case BuiltinType::Ibm128:
2849-
case BuiltinType::Float128: {
2813+
// Issue an error for any type not explicitly handled.
2814+
default:
28502815
Error(Range.getBegin(), "built-in type: ",
28512816
T->getName(Context.getASTContext().getPrintingPolicy()))
28522817
<< Range;
28532818
break;
28542819
}
2855-
}
28562820
}
28572821

28582822
// <type> ::= <function-type>

0 commit comments

Comments
 (0)