Skip to content

Commit 63ec52f

Browse files
committed
MCAssembler::layout: remove the unused MCAsmLayout parameter
Almost complete the MCAsmLayout removal work started by 67957a4.
1 parent bbb5036 commit 63ec52f

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

bolt/lib/Core/BinaryContext.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include "llvm/DebugInfo/DWARF/DWARFCompileUnit.h"
2121
#include "llvm/DebugInfo/DWARF/DWARFFormValue.h"
2222
#include "llvm/DebugInfo/DWARF/DWARFUnit.h"
23-
#include "llvm/MC/MCAsmLayout.h"
2423
#include "llvm/MC/MCAssembler.h"
2524
#include "llvm/MC/MCContext.h"
2625
#include "llvm/MC/MCDisassembler/MCDisassembler.h"
@@ -2416,8 +2415,7 @@ BinaryContext::calculateEmittedSize(BinaryFunction &BF, bool FixBranches) {
24162415

24172416
MCAssembler &Assembler =
24182417
static_cast<MCObjectStreamer *>(Streamer.get())->getAssembler();
2419-
MCAsmLayout Layout(Assembler);
2420-
Assembler.layout(Layout);
2418+
Assembler.layout();
24212419

24222420
// Obtain fragment sizes.
24232421
std::vector<uint64_t> FragmentSizes;

llvm/include/llvm/MC/MCAssembler.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class MCRelaxableFragment;
4646
class MCSymbolRefExpr;
4747
class raw_ostream;
4848
class MCAsmBackend;
49-
class MCAsmLayout;
5049
class MCContext;
5150
class MCCodeEmitter;
5251
class MCFragment;
@@ -341,7 +340,7 @@ class MCAssembler {
341340
void Finish();
342341

343342
// Layout all section and prepare them for emission.
344-
void layout(MCAsmLayout &Layout);
343+
void layout();
345344

346345
// FIXME: This does not belong here.
347346
bool getSubsectionsViaSymbols() const { return SubsectionsViaSymbols; }

llvm/lib/MC/MCAssembler.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include "llvm/ADT/Twine.h"
1616
#include "llvm/MC/MCAsmBackend.h"
1717
#include "llvm/MC/MCAsmInfo.h"
18-
#include "llvm/MC/MCAsmLayout.h"
1918
#include "llvm/MC/MCCodeEmitter.h"
2019
#include "llvm/MC/MCCodeView.h"
2120
#include "llvm/MC/MCContext.h"
@@ -937,7 +936,7 @@ MCAssembler::handleFixup(MCFragment &F, const MCFixup &Fixup,
937936
return std::make_tuple(Target, FixedValue, IsResolved);
938937
}
939938

940-
void MCAssembler::layout(MCAsmLayout &Layout) {
939+
void MCAssembler::layout() {
941940
assert(getBackendPtr() && "Expected assembler backend");
942941
DEBUG_WITH_TYPE("mc-dump", {
943942
errs() << "assembler backend - pre-layout\n--\n";
@@ -1074,9 +1073,7 @@ void MCAssembler::layout(MCAsmLayout &Layout) {
10741073
}
10751074

10761075
void MCAssembler::Finish() {
1077-
// Create the layout object.
1078-
MCAsmLayout Layout(*this);
1079-
layout(Layout);
1076+
layout();
10801077

10811078
// Write the object file.
10821079
stats::ObjectBytes += getWriter().writeObject(*this);

llvm/lib/MC/MCExpr.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "llvm/Config/llvm-config.h"
1313
#include "llvm/MC/MCAsmBackend.h"
1414
#include "llvm/MC/MCAsmInfo.h"
15-
#include "llvm/MC/MCAsmLayout.h"
1615
#include "llvm/MC/MCAssembler.h"
1716
#include "llvm/MC/MCContext.h"
1817
#include "llvm/MC/MCObjectWriter.h"

llvm/tools/dsymutil/MachOUtils.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "LinkUtils.h"
1313
#include "llvm/ADT/SmallString.h"
1414
#include "llvm/CodeGen/NonRelocatableStringpool.h"
15-
#include "llvm/MC/MCAsmLayout.h"
1615
#include "llvm/MC/MCAssembler.h"
1716
#include "llvm/MC/MCMachObjectWriter.h"
1817
#include "llvm/MC/MCObjectStreamer.h"
@@ -381,8 +380,7 @@ bool generateDsymCompanion(
381380
auto &Writer = static_cast<MachObjectWriter &>(MCAsm.getWriter());
382381

383382
// Layout but don't emit.
384-
MCAsmLayout Layout(MCAsm);
385-
MCAsm.layout(Layout);
383+
MCAsm.layout();
386384

387385
BinaryHolder InputBinaryHolder(VFS, false);
388386

0 commit comments

Comments
 (0)