Make VisitSubstNonTypeTemplateParmExpr always return true.

rniwa · rniwa · commit 647493b5c550 · 2024-04-30T23:08:32.000-07:00
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
@@ -372,8 +372,8 @@ class TrivialFunctionAnalysisVisitor
 
   bool
   VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
-    // Non-type template paramter is trivial if the replacement is trivial.
-    return Visit(E->getReplacement());
+    // Non-type template paramter is compile time constant and trivial.
+    return true;
   }
 
   bool VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *E) {

Original file line number	Diff line number	Diff line change
`@@ -372,8 +372,8 @@ class TrivialFunctionAnalysisVisitor`
`372`	`372`
`373`	`373`	`bool`
`374`	`374`	`VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {`
`375`		`- // Non-type template paramter is trivial if the replacement is trivial.`
`376`		`- return Visit(E->getReplacement());`
	`375`	`+ // Non-type template paramter is compile time constant and trivial.`
	`376`	`+ return true;`
`377`	`377`	`}`
`378`	`378`
`379`	`379`	`bool VisitUnaryExprOrTypeTraitExpr(const UnaryExprOrTypeTraitExpr *E) {`