Skip to content

Commit 64bcb07

Browse files
committed
address comments
1 parent 1e9acb5 commit 64bcb07

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -862,21 +862,19 @@ NVPTXTargetLowering::NVPTXTargetLowering(const NVPTXTargetMachine &TM,
862862
setOperationAction(Op, MVT::bf16, Promote);
863863
AddPromotedToType(Op, MVT::bf16, MVT::f32);
864864
}
865-
for (const auto &Op : {ISD::FABS}) {
866-
setOperationAction(Op, MVT::f32, Legal);
867-
setOperationAction(Op, MVT::f64, Legal);
868-
if (STI.getPTXVersion() >= 65) {
869-
setFP16OperationAction(Op, MVT::f16, Legal, Promote);
870-
setFP16OperationAction(Op, MVT::v2f16, Legal, Expand);
871-
} else {
872-
setOperationAction(Op, MVT::f16, Promote);
873-
setOperationAction(Op, MVT::v2f16, Expand);
874-
}
875-
setBF16OperationAction(Op, MVT::v2bf16, Legal, Expand);
876-
setBF16OperationAction(Op, MVT::bf16, Legal, Promote);
877-
if (getOperationAction(Op, MVT::bf16) == Promote)
878-
AddPromotedToType(Op, MVT::bf16, MVT::f32);
865+
866+
setOperationAction(ISD::FABS, {MVT::f32, MVT::f64}, Legal);
867+
if (STI.getPTXVersion() >= 65) {
868+
setFP16OperationAction(ISD::FABS, MVT::f16, Legal, Promote);
869+
setFP16OperationAction(ISD::FABS, MVT::v2f16, Legal, Expand);
870+
} else {
871+
setOperationAction(ISD::FABS, MVT::f16, Promote);
872+
setOperationAction(ISD::FABS, MVT::v2f16, Expand);
879873
}
874+
setBF16OperationAction(ISD::FABS, MVT::v2bf16, Legal, Expand);
875+
setBF16OperationAction(ISD::FABS, MVT::bf16, Legal, Promote);
876+
if (getOperationAction(ISD::FABS, MVT::bf16) == Promote)
877+
AddPromotedToType(ISD::FABS, MVT::bf16, MVT::f32);
880878

881879
for (const auto &Op : {ISD::FMINNUM, ISD::FMAXNUM}) {
882880
setOperationAction(Op, MVT::f32, Legal);

0 commit comments

Comments
 (0)