Skip to content

Commit 65b0d21

Browse files
committed
[lldb] Remove "error:" prefix from reverse execute error messages
Errors will get "error:" prefixes automatically so this is not needed.
1 parent 2e713af commit 65b0d21

File tree

5 files changed

+6
-10
lines changed

5 files changed

+6
-10
lines changed

lldb/include/lldb/Target/Process.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,10 +1114,9 @@ class Process : public std::enable_shared_from_this<Process>,
11141114
virtual Status DoResume(lldb::RunDirection direction) {
11151115
if (direction == lldb::RunDirection::eRunForward)
11161116
return Status::FromErrorStringWithFormatv(
1117-
"error: {0} does not support resuming processes", GetPluginName());
1117+
"{0} does not support resuming processes", GetPluginName());
11181118
return Status::FromErrorStringWithFormatv(
1119-
"error: {0} does not support reverse execution of processes",
1120-
GetPluginName());
1119+
"{0} does not support reverse execution of processes", GetPluginName());
11211120
}
11221121

11231122
/// Called after resuming a process.

lldb/source/API/SBProcess.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ SBError SBProcess::ContinueInDirection(RunDirection direction) {
590590
if (direction == RunDirection::eRunReverse &&
591591
!process_sp->SupportsReverseDirection())
592592
return Status::FromErrorStringWithFormatv(
593-
"error: {0} does not support reverse execution of processes",
593+
"{0} does not support reverse execution of processes",
594594
GetPluginName());
595595
process_sp->SetBaseDirection(direction);
596596
}

lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,7 @@ Status ProcessKDP::DoResume(RunDirection direction) {
403403

404404
if (direction == RunDirection::eRunReverse)
405405
return Status::FromErrorStringWithFormatv(
406-
"error: {0} does not support reverse execution of processes",
407-
GetPluginName());
406+
"{0} does not support reverse execution of processes", GetPluginName());
408407

409408
// Only start the async thread if we try to do any process control
410409
if (!m_async_thread.IsJoinable())

lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,7 @@ Status ProcessWindows::DoResume(RunDirection direction) {
242242

243243
if (direction == RunDirection::eRunReverse) {
244244
return Status::FromErrorStringWithFormatv(
245-
"error: {0} does not support reverse execution of processes",
246-
GetPluginName());
245+
"{0} does not support reverse execution of processes", GetPluginName());
247246
}
248247

249248
Status error;

lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ Status ScriptedProcess::DoResume(RunDirection direction) {
191191
return GetInterface().Resume();
192192
// FIXME: Pipe reverse continue through Scripted Processes
193193
return Status::FromErrorStringWithFormatv(
194-
"error: {0} does not support reverse execution of processes",
195-
GetPluginName());
194+
"{0} does not support reverse execution of processes", GetPluginName());
196195
}
197196

198197
Status ScriptedProcess::DoAttach(const ProcessAttachInfo &attach_info) {

0 commit comments

Comments
 (0)