Skip to content

Commit 66465c3

Browse files
Revert "Make llvm::telemetry::Manager::preDispatch protected. (#127114)"
This reverts commit f7a2d70. Multiple buildbot failures have been reported. See: #127114
1 parent 3063153 commit 66465c3

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

llvm/include/llvm/Telemetry/Telemetry.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,10 @@ class Manager {
138138
public:
139139
virtual ~Manager() = default;
140140

141+
// Optional callback for subclasses to perform additional tasks before
142+
// dispatching to Destinations.
143+
virtual Error preDispatch(TelemetryInfo *Entry) = 0;
144+
141145
// Dispatch Telemetry data to the Destination(s).
142146
// The argument is non-const because the Manager may add or remove
143147
// data from the entry.
@@ -146,11 +150,6 @@ class Manager {
146150
// Register a Destination.
147151
void addDestination(std::unique_ptr<Destination> Destination);
148152

149-
protected:
150-
// Optional callback for subclasses to perform additional tasks before
151-
// dispatching to Destinations.
152-
virtual Error preDispatch(TelemetryInfo *Entry) {}
153-
154153
private:
155154
std::vector<std::unique_ptr<Destination>> Destinations;
156155
};

llvm/lib/Telemetry/Telemetry.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
1-
//===----------------------------------------------------------------------===//
2-
//
3-
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4-
// See https://llvm.org/LICENSE.txt for license information.
5-
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6-
//
7-
//===----------------------------------------------------------------------===//
8-
///
9-
/// \file
10-
/// This file provides the basic framework for Telemetry.
11-
/// Refer to its documentation at llvm/docs/Telemetry.rst for more details.
12-
//===---------------------------------------------------------------------===//
13-
141
#include "llvm/Telemetry/Telemetry.h"
152

163
namespace llvm {

0 commit comments

Comments
 (0)