Skip to content

Commit 6656e96

Browse files
committed
[mlir] Fix compilation warnings
Fixes: - (MSVC) F:\llvm-project\mlir\lib\Dialect\Linalg\Analysis\DependenceAnalysis.cpp(103): warning C4551: function call missing argument list - (Clang) tools\mlir\lib\Dialect\SPIRV\SPIRVCanonicalization.inc(232,1): warning: unused function 'populateWithGenerated' [-Wunused-function]
1 parent 316f600 commit 6656e96

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

mlir/lib/Dialect/Linalg/Analysis/DependenceAnalysis.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ using namespace mlir::linalg;
2424

2525
using llvm::dbgs;
2626

27+
#ifndef NDEBUG
2728
static StringRef toStringRef(LinalgDependenceGraph::DependenceType dt) {
2829
switch (dt) {
2930
case LinalgDependenceGraph::DependenceType::RAW:
@@ -39,6 +40,7 @@ static StringRef toStringRef(LinalgDependenceGraph::DependenceType dt) {
3940
}
4041
llvm_unreachable("Unexpected DependenceType");
4142
}
43+
#endif
4244

4345
Value Aliases::find(Value v) {
4446
if (v.isa<BlockArgument>())
@@ -100,7 +102,6 @@ void LinalgDependenceGraph::addDependenceElem(DependenceType dt,
100102
LinalgOpView dependentOpView) {
101103
LLVM_DEBUG(dbgs() << "\nAdd dep type " << toStringRef(dt) << ":\t"
102104
<< *indexingOpView.op << " -> " << *dependentOpView.op);
103-
(void)toStringRef;
104105
dependencesFromGraphs[dt][indexingOpView.op].push_back(
105106
LinalgDependenceGraphElem{dependentOpView, indexingOpView.view});
106107
dependencesIntoGraphs[dt][dependentOpView.op].push_back(

mlir/tools/mlir-tblgen/RewriterGen.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1020,8 +1020,11 @@ static void emitRewriters(const RecordKeeper &recordKeeper, raw_ostream &os) {
10201020
}
10211021

10221022
// Emit function to add the generated matchers to the pattern list.
1023-
os << "void __attribute__((unused)) populateWithGenerated(MLIRContext "
1024-
"*context, "
1023+
os << "void\n";
1024+
os << "#if !defined(_MSC_VER) || defined(__clang__)\n";
1025+
os << "__attribute__((unused))\n";
1026+
os << "#endif\n";
1027+
os << "populateWithGenerated(MLIRContext *context, "
10251028
<< "OwningRewritePatternList *patterns) {\n";
10261029
for (const auto &name : rewriterNames) {
10271030
os << " patterns->insert<" << name << ">(context);\n";

0 commit comments

Comments
 (0)