Skip to content

Commit 66878ff

Browse files
[Hexagon] Use range-based for loops (NFC) (#104538)
1 parent 7aa4726 commit 66878ff

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

llvm/lib/Target/Hexagon/HexagonCopyHoisting.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,7 @@ void HexagonCopyHoisting::moveCopyInstr(MachineBasicBlock *DestBB,
249249
DestBB->splice(FirstTI, MI->getParent(), MI);
250250

251251
addMItoCopyList(MI);
252-
for (auto I = std::next(DestBB->succ_begin()), E = DestBB->succ_end(); I != E;
253-
++I) {
254-
MachineBasicBlock *SuccBB = *I;
252+
for (MachineBasicBlock *SuccBB : drop_begin(DestBB->successors())) {
255253
auto &BBCopyInst = CopyMIList[SuccBB->getNumber()];
256254
MachineInstr *SuccMI = BBCopyInst[Key];
257255
SuccMI->eraseFromParent();

llvm/lib/Target/Hexagon/HexagonGenMemAbsolute.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,9 @@ bool HexagonGenMemAbsolute::runOnMachineFunction(MachineFunction &Fn) {
8686
getAnalysis<MachineDominatorTreeWrapperPass>().getDomTree();
8787

8888
// Loop over all of the basic blocks
89-
for (MachineFunction::iterator MBBb = Fn.begin(), MBBe = Fn.end();
90-
MBBb != MBBe; ++MBBb) {
91-
MachineBasicBlock *MBB = &*MBBb;
89+
for (MachineBasicBlock &MBB : Fn) {
9290
// Traverse the basic block
93-
for (MachineBasicBlock::iterator MII = MBB->begin(); MII != MBB->end();
91+
for (MachineBasicBlock::iterator MII = MBB.begin(); MII != MBB.end();
9492
++MII) {
9593
MachineInstr *MI = &*MII;
9694
int Opc = MI->getOpcode();
@@ -205,7 +203,7 @@ bool HexagonGenMemAbsolute::runOnMachineFunction(MachineFunction &Fn) {
205203

206204
LLVM_DEBUG(dbgs() << "Replaced with " << *MIB << "\n");
207205
// Erase the instructions that got replaced.
208-
MII = MBB->erase(MI);
206+
MII = MBB.erase(MI);
209207
--MII;
210208
NextMI->getParent()->erase(NextMI);
211209
}

0 commit comments

Comments
 (0)