Skip to content

Commit 673b5dd

Browse files
Revert "Introduce symbol versioning for clang-cpp (#116556)"
This reverts commit 944478d. Reverted because of following error on greendragon ld: unknown options: --version-script clang: error: linker command failed with exit code 1 (use -v to see invocation)
1 parent f981ee7 commit 673b5dd

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

clang/tools/clang-shlib/CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,6 @@ add_clang_library(clang-cpp
4848
${_OBJECTS}
4949
LINK_LIBS
5050
${_DEPS})
51-
52-
configure_file(simple_version_script.map.in simple_version_script.map)
53-
54-
if (NOT LLVM_LINKER_IS_SOLARISLD AND NOT MINGW)
55-
# Solaris ld does not accept global: *; so there is no way to version *all* global symbols
56-
target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
57-
endif()
58-
5951
# Optimize function calls for default visibility definitions to avoid PLT and
6052
# reduce dynamic relocations.
6153
if (NOT APPLE AND NOT MINGW AND NOT LLVM_LINKER_IS_SOLARISLD_ILLUMOS)

clang/tools/clang-shlib/simple_version_script.map.in

Lines changed: 0 additions & 1 deletion
This file was deleted.

llvm/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (NOT PACKAGE_VERSION)
2727
endif()
2828

2929
if(NOT DEFINED LLVM_SHLIB_SYMBOL_VERSION)
30-
# "Symbol version prefix for libLLVM.so and libclang-cpp.so"
30+
# "Symbol version prefix for libLLVM.so"
3131
set(LLVM_SHLIB_SYMBOL_VERSION "LLVM_${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}")
3232
endif()
3333

0 commit comments

Comments
 (0)