Skip to content

Commit 67c974b

Browse files
authored
[lldb][DWARFASTParserClang][NFC] Remove redundant parameter to ParseChildParameters (#121033)
This was never set to anything other than `true`.
1 parent 207e485 commit 67c974b

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,11 +1222,9 @@ DWARFASTParserClang::ParseSubroutine(const DWARFDIE &die,
12221222
}
12231223

12241224
if (die.HasChildren()) {
1225-
bool skip_artificial = true;
1226-
ParseChildParameters(containing_decl_ctx, die, skip_artificial, is_static,
1227-
is_variadic, has_template_params,
1228-
function_param_types, function_param_decls,
1229-
type_quals);
1225+
ParseChildParameters(containing_decl_ctx, die, is_static, is_variadic,
1226+
has_template_params, function_param_types,
1227+
function_param_decls, type_quals);
12301228
}
12311229

12321230
bool ignore_containing_context = false;
@@ -2325,7 +2323,7 @@ DWARFASTParserClang::ConstructDemangledNameFromDWARF(const DWARFDIE &die) {
23252323

23262324
clang::DeclContext *containing_decl_ctx =
23272325
GetClangDeclContextContainingDIE(die, nullptr);
2328-
ParseChildParameters(containing_decl_ctx, die, true, is_static, is_variadic,
2326+
ParseChildParameters(containing_decl_ctx, die, is_static, is_variadic,
23292327
has_template_params, param_types, param_decls,
23302328
type_quals);
23312329
sstr << "(";
@@ -3069,8 +3067,8 @@ bool DWARFASTParserClang::ParseChildMembers(
30693067

30703068
size_t DWARFASTParserClang::ParseChildParameters(
30713069
clang::DeclContext *containing_decl_ctx, const DWARFDIE &parent_die,
3072-
bool skip_artificial, bool &is_static, bool &is_variadic,
3073-
bool &has_template_params, std::vector<CompilerType> &function_param_types,
3070+
bool &is_static, bool &is_variadic, bool &has_template_params,
3071+
std::vector<CompilerType> &function_param_types,
30743072
std::vector<clang::ParmVarDecl *> &function_param_decls,
30753073
unsigned &type_quals) {
30763074
if (!parent_die)
@@ -3125,7 +3123,7 @@ size_t DWARFASTParserClang::ParseChildParameters(
31253123
}
31263124

31273125
bool skip = false;
3128-
if (skip_artificial && is_artificial) {
3126+
if (is_artificial) {
31293127
// In order to determine if a C++ member function is "const" we
31303128
// have to look at the const-ness of "this"...
31313129
if (arg_idx == 0 &&

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class DWARFASTParserClang : public lldb_private::plugin::dwarf::DWARFASTParser {
189189
size_t
190190
ParseChildParameters(clang::DeclContext *containing_decl_ctx,
191191
const lldb_private::plugin::dwarf::DWARFDIE &parent_die,
192-
bool skip_artificial, bool &is_static, bool &is_variadic,
192+
bool &is_static, bool &is_variadic,
193193
bool &has_template_params,
194194
std::vector<lldb_private::CompilerType> &function_args,
195195
std::vector<clang::ParmVarDecl *> &function_param_decls,

0 commit comments

Comments
 (0)