Skip to content

Commit 6aef8df

Browse files
authored
[libcxx] Update 128-bit-atomics feature test (#83841)
The `128-bit-atomics` libcxx feature is incorrectly named because tests that are Xfailed with it is really using `int[128]`. Additionally, because toolchain support for that feature is determined based on a much smaller size (`char[16]`), tests would execute incorrectly without required toolchain support. So, rename `128-bit-atomics` as `1024-bit-atomics`, and use an appropriate type to check for the presence of the feature.
1 parent 6d4aa9d commit 6aef8df

18 files changed

+19
-19
lines changed

libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
//
99
// UNSUPPORTED: c++03
10-
// REQUIRES: has-128-bit-atomics
10+
// REQUIRES: has-1024-bit-atomics
1111
// ADDITIONAL_COMPILE_FLAGS: -Wno-psabi
1212
// ... since C++20 std::__atomic_base initializes, so we get a warning about an
1313
// ABI change for vector variants since the constructor code for that is

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_strong.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_strong_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_weak.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_weak_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_exchange.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_exchange_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_init.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
1111

1212
// <atomic>

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_load.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_load_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_store.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_store_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: !has-128-bit-atomics
9+
// XFAIL: !has-1024-bit-atomics
1010

1111
// <atomic>
1212

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_notify_all.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
//
99
// UNSUPPORTED: no-threads
1010
// XFAIL: c++03
11-
// XFAIL: !has-128-bit-atomics
11+
// XFAIL: !has-1024-bit-atomics
1212

1313
// XFAIL: availability-synchronization_library-missing
1414

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_notify_one.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
//
99
// UNSUPPORTED: no-threads
1010
// XFAIL: c++03
11-
// XFAIL: !has-128-bit-atomics
11+
// XFAIL: !has-1024-bit-atomics
1212

1313
// XFAIL: availability-synchronization_library-missing
1414

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
//
99
// UNSUPPORTED: no-threads
1010
// XFAIL: c++03
11-
// XFAIL: !has-128-bit-atomics
11+
// XFAIL: !has-1024-bit-atomics
1212

1313
// XFAIL: availability-synchronization_library-missing
1414

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait_explicit.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
//
99
// UNSUPPORTED: no-threads
1010
// XFAIL: c++03
11-
// XFAIL: !has-128-bit-atomics
11+
// XFAIL: !has-1024-bit-atomics
1212

1313
// XFAIL: availability-synchronization_library-missing
1414

libcxx/utils/libcxx/test/features.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,12 @@ def _getAndroidDeviceApi(cfg):
171171
),
172172
),
173173
Feature(
174-
name="has-128-bit-atomics",
174+
name="has-1024-bit-atomics",
175175
when=lambda cfg: sourceBuilds(
176176
cfg,
177177
"""
178178
#include <atomic>
179-
struct Large { char storage[128/8]; };
179+
struct Large { int storage[1024/8]; };
180180
std::atomic<Large> x;
181181
int main(int, char**) { (void)x.load(); (void)x.is_lock_free(); return 0; }
182182
""",

0 commit comments

Comments
 (0)