Skip to content

Commit 6b248fc

Browse files
committed
[NFC][PhaseOrdering] Add tests showcasing the problems of unsigned multiply overflow check
While we can form the @llvm.mul.with.overflow easily, we are still left with that check that was guarding against div-by-0. And in the second case we won't even flatten the CFG. llvm-svn: 366747
1 parent d5a52ae commit 6b248fc

File tree

1 file changed

+85
-0
lines changed

1 file changed

+85
-0
lines changed
Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -simplifycfg -S < %s | FileCheck %s --check-prefixes=ALL,SIMPLIFYCFG
3+
; RUN: opt -instcombine -S < %s | FileCheck %s --check-prefixes=ALL,INSTCOMBINE,INSTCOMBINEONLY
4+
; RUN: opt -instcombine -simplifycfg -S < %s | FileCheck %s --check-prefixes=ALL,INSTCOMBINE,BOTH
5+
6+
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
7+
target triple = "x86_64-pc-linux-gnu"
8+
9+
; #include <limits>
10+
; #include <cstdint>
11+
;
12+
; using size_type = std::size_t;
13+
; bool will_not_overflow(size_type size, size_type nmemb) {
14+
; return (size != 0 && (nmemb > std::numeric_limits<size_type>::max() / size));
15+
; }
16+
17+
define i1 @will_not_overflow(i64 %arg, i64 %arg1) {
18+
; ALL-LABEL: @will_not_overflow(
19+
; ALL-NEXT: bb:
20+
; ALL-NEXT: [[T0:%.*]] = icmp eq i64 [[ARG:%.*]], 0
21+
; ALL-NEXT: br i1 [[T0]], label [[BB5:%.*]], label [[BB2:%.*]]
22+
; ALL: bb2:
23+
; ALL-NEXT: [[T3:%.*]] = udiv i64 -1, [[ARG]]
24+
; ALL-NEXT: [[T4:%.*]] = icmp ult i64 [[T3]], [[ARG1:%.*]]
25+
; ALL-NEXT: br label [[BB5]]
26+
; ALL: bb5:
27+
; ALL-NEXT: [[T6:%.*]] = phi i1 [ false, [[BB:%.*]] ], [ [[T4]], [[BB2]] ]
28+
; ALL-NEXT: ret i1 [[T6]]
29+
;
30+
bb:
31+
%t0 = icmp eq i64 %arg, 0
32+
br i1 %t0, label %bb5, label %bb2
33+
34+
bb2: ; preds = %bb
35+
%t3 = udiv i64 -1, %arg
36+
%t4 = icmp ult i64 %t3, %arg1
37+
br label %bb5
38+
39+
bb5: ; preds = %bb2, %bb
40+
%t6 = phi i1 [ false, %bb ], [ %t4, %bb2 ]
41+
ret i1 %t6
42+
}
43+
44+
; Same as @will_not_overflow, but inverting return value.
45+
46+
define i1 @will_overflow(i64 %arg, i64 %arg1) {
47+
; SIMPLIFYCFG-LABEL: @will_overflow(
48+
; SIMPLIFYCFG-NEXT: bb:
49+
; SIMPLIFYCFG-NEXT: [[T0:%.*]] = icmp eq i64 [[ARG:%.*]], 0
50+
; SIMPLIFYCFG-NEXT: br i1 [[T0]], label [[BB5:%.*]], label [[BB2:%.*]]
51+
; SIMPLIFYCFG: bb2:
52+
; SIMPLIFYCFG-NEXT: [[T3:%.*]] = udiv i64 -1, [[ARG]]
53+
; SIMPLIFYCFG-NEXT: [[T4:%.*]] = icmp ult i64 [[T3]], [[ARG1:%.*]]
54+
; SIMPLIFYCFG-NEXT: br label [[BB5]]
55+
; SIMPLIFYCFG: bb5:
56+
; SIMPLIFYCFG-NEXT: [[T6:%.*]] = phi i1 [ false, [[BB:%.*]] ], [ [[T4]], [[BB2]] ]
57+
; SIMPLIFYCFG-NEXT: [[T7:%.*]] = xor i1 [[T6]], true
58+
; SIMPLIFYCFG-NEXT: ret i1 [[T7]]
59+
;
60+
; INSTCOMBINE-LABEL: @will_overflow(
61+
; INSTCOMBINE-NEXT: bb:
62+
; INSTCOMBINE-NEXT: [[T0:%.*]] = icmp eq i64 [[ARG:%.*]], 0
63+
; INSTCOMBINE-NEXT: br i1 [[T0]], label [[BB5:%.*]], label [[BB2:%.*]]
64+
; INSTCOMBINE: bb2:
65+
; INSTCOMBINE-NEXT: [[T3:%.*]] = udiv i64 -1, [[ARG]]
66+
; INSTCOMBINE-NEXT: [[T4:%.*]] = icmp uge i64 [[T3]], [[ARG1:%.*]]
67+
; INSTCOMBINE-NEXT: br label [[BB5]]
68+
; INSTCOMBINE: bb5:
69+
; INSTCOMBINE-NEXT: [[T6:%.*]] = phi i1 [ true, [[BB:%.*]] ], [ [[T4]], [[BB2]] ]
70+
; INSTCOMBINE-NEXT: ret i1 [[T6]]
71+
;
72+
bb:
73+
%t0 = icmp eq i64 %arg, 0
74+
br i1 %t0, label %bb5, label %bb2
75+
76+
bb2: ; preds = %bb
77+
%t3 = udiv i64 -1, %arg
78+
%t4 = icmp ult i64 %t3, %arg1
79+
br label %bb5
80+
81+
bb5: ; preds = %bb2, %bb
82+
%t6 = phi i1 [ false, %bb ], [ %t4, %bb2 ]
83+
%t7 = xor i1 %t6, true
84+
ret i1 %t7
85+
}

0 commit comments

Comments
 (0)