Skip to content

Commit 6cfa03f

Browse files
authored
[ORC] Drop unused LinkGraphLinkingLayer::Plugin::notifyLoaded method. (#145457)
This method was included in the original Plugin API as a counterpart to JITEventListener::notifyLoaded but was never used.
1 parent 5fa55b2 commit 6cfa03f

File tree

3 files changed

+0
-11
lines changed

3 files changed

+0
-11
lines changed

llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ class MyPlugin : public ObjectLinkingLayer::Plugin {
7070
Config.PostPrunePasses.push_back(printGraph);
7171
}
7272

73-
void notifyLoaded(MaterializationResponsibility &MR) override {
74-
outs() << "Loading object defining " << MR.getSymbols() << "\n";
75-
}
76-
7773
Error notifyEmitted(MaterializationResponsibility &MR) override {
7874
outs() << "Emitted object defining " << MR.getSymbols() << "\n";
7975
return Error::success();

llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ class LLVM_ABI LinkGraphLinkingLayer : public LinkGraphLayer,
6363
jitlink::JITLinkContext &Ctx,
6464
MemoryBufferRef InputObject) {}
6565

66-
virtual void notifyLoaded(MaterializationResponsibility &MR) {}
6766
virtual Error notifyEmitted(MaterializationResponsibility &MR) {
6867
return Error::success();
6968
}

llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ class LinkGraphLinkingLayer::JITLinkCtx final : public JITLinkContext {
207207
if (auto Err = MR->notifyResolved(InternedResult))
208208
return Err;
209209

210-
notifyLoaded();
211210
return Error::success();
212211
}
213212

@@ -244,11 +243,6 @@ class LinkGraphLinkingLayer::JITLinkCtx final : public JITLinkContext {
244243
return Error::success();
245244
}
246245

247-
void notifyLoaded() {
248-
for (auto &P : Plugins)
249-
P->notifyLoaded(*MR);
250-
}
251-
252246
Error notifyEmitted(jitlink::JITLinkMemoryManager::FinalizedAlloc FA) {
253247
Error Err = Error::success();
254248
for (auto &P : Plugins)

0 commit comments

Comments
 (0)