Skip to content

Commit 6d0ca5a

Browse files
committed
[MLIR][OpenMP][test] Update omp::FlagsAttr tests to only use CHECK tests
The CHECK-NOT tests were incorrect and impacting the other tests flag tests negatively, they'd pass as false positives.
1 parent 2f5477d commit 6d0ca5a

File tree

1 file changed

+4
-48
lines changed

1 file changed

+4
-48
lines changed

mlir/test/Target/LLVMIR/openmp-llvm.mlir

Lines changed: 4 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -2457,55 +2457,22 @@ llvm.func @omp_opaque_pointers(%arg0 : !llvm.ptr, %arg1: !llvm.ptr, %expr: i32)
24572457

24582458
// -----
24592459

2460-
// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 1
2461-
// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
2462-
// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 1
2463-
// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
2464-
// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 1
2465-
module attributes {omp.flags = #omp.flags<debug_kind = 1, assume_teams_oversubscription = true,
2466-
assume_threads_oversubscription = true, assume_no_thread_state = true,
2467-
assume_no_nested_parallelism = true>} {}
2468-
2469-
// -----
2470-
24712460
// CHECK: @__omp_rtl_debug_kind = weak_odr hidden constant i32 1
24722461
// CHECK: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
24732462
// CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 1
24742463
// CHECK: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
24752464
// CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 1
24762465
module attributes {omp.flags = #omp.flags<debug_kind = 1, assume_teams_oversubscription = true,
24772466
assume_threads_oversubscription = true, assume_no_thread_state = true,
2478-
assume_no_nested_parallelism = true>,
2479-
omp.is_device = #omp.isdevice<is_device = true>} {}
2480-
2481-
// -----
2482-
2483-
// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
2484-
// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 0
2485-
// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
2486-
// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
2487-
// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
2488-
module attributes {omp.flags = #omp.flags<>} {}
2489-
2467+
assume_no_nested_parallelism = true>} {}
24902468
// -----
24912469

24922470
// CHECK: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
24932471
// CHECK: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 0
24942472
// CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
24952473
// CHECK: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
24962474
// CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
2497-
module attributes {omp.flags = #omp.flags<>, omp.is_device = #omp.isdevice<is_device = true>} {}
2498-
2499-
// -----
2500-
2501-
// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
2502-
// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 0
2503-
// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
2504-
// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 0
2505-
// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
2506-
module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubscription = false,
2507-
assume_threads_oversubscription = false, assume_no_thread_state = false,
2508-
assume_no_nested_parallelism = false>} {}
2475+
module attributes {omp.flags = #omp.flags<>} {}
25092476

25102477
// -----
25112478

@@ -2516,17 +2483,7 @@ module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubsc
25162483
// CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
25172484
module attributes {omp.flags = #omp.flags<debug_kind = 0, assume_teams_oversubscription = false,
25182485
assume_threads_oversubscription = false, assume_no_thread_state = false,
2519-
assume_no_nested_parallelism = false>,
2520-
omp.is_device = #omp.isdevice<is_device = true>} {}
2521-
2522-
// -----
2523-
2524-
// CHECK-NOT: @__omp_rtl_debug_kind = weak_odr hidden constant i32 0
2525-
// CHECK-NOT: @__omp_rtl_assume_teams_oversubscription = weak_odr hidden constant i32 1
2526-
// CHECK-NOT: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
2527-
// CHECK-NOT: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
2528-
// CHECK-NOT: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
2529-
module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>} {}
2486+
assume_no_nested_parallelism = false>} {}
25302487

25312488
// -----
25322489

@@ -2535,5 +2492,4 @@ module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true,
25352492
// CHECK: @__omp_rtl_assume_threads_oversubscription = weak_odr hidden constant i32 0
25362493
// CHECK: @__omp_rtl_assume_no_thread_state = weak_odr hidden constant i32 1
25372494
// CHECK: @__omp_rtl_assume_no_nested_parallelism = weak_odr hidden constant i32 0
2538-
module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>,
2539-
omp.is_device = #omp.isdevice<is_device = true>} {}
2495+
module attributes {omp.flags = #omp.flags<assume_teams_oversubscription = true, assume_no_thread_state = true>} {}

0 commit comments

Comments
 (0)