Skip to content

Commit 6d18951

Browse files
Remove the builtin_headers_in_system_modules feature (#75262)
__has_feature(builtin_headers_in_system_modules) was added in https://reviews.llvm.org/D159483 to be used in the stdarg/stddef implementation headers. It ended up being unnecessary, but I forgot to remove the feature definition.
1 parent 1220edc commit 6d18951

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

clang/include/clang/Basic/Features.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,6 @@ EXTENSION(matrix_types_scalar_division, true)
282282
EXTENSION(cxx_attributes_on_using_declarations, LangOpts.CPlusPlus11)
283283
EXTENSION(datasizeof, LangOpts.CPlusPlus)
284284

285-
FEATURE(builtin_headers_in_system_modules, LangOpts.BuiltinHeadersInSystemModules)
286285
FEATURE(cxx_abi_relative_vtable, LangOpts.CPlusPlus && LangOpts.RelativeCXXABIVTables)
287286

288287
// CUDA/HIP Features

clang/test/Driver/darwin-builtin-modules.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,3 @@
99
// RUN: %clang -isysroot %S/Inputs/MacOSX99.0.sdk -target x86_64-apple-macos98.0 -### %s 2>&1 | FileCheck --check-prefix=CHECK_FUTURE %s
1010
// RUN: %clang -isysroot %S/Inputs/MacOSX99.0.sdk -target x86_64-apple-macos99.0 -### %s 2>&1 | FileCheck --check-prefix=CHECK_FUTURE %s
1111
// CHECK_FUTURE-NOT: -fbuiltin-headers-in-system-modules
12-
13-
14-
// Check that builtin_headers_in_system_modules is only set if -fbuiltin-headers-in-system-modules and -fmodules are both set.
15-
16-
// RUN: %clang -isysroot %S/Inputs/iPhoneOS13.0.sdk -target arm64-apple-ios13.0 -fsyntax-only %s -Xclang -verify=no-feature
17-
// RUN: %clang -isysroot %S/Inputs/iPhoneOS13.0.sdk -target arm64-apple-ios13.0 -fsyntax-only %s -fmodules -Xclang -verify=yes-feature
18-
// RUN: %clang -isysroot %S/Inputs/MacOSX99.0.sdk -target x86_64-apple-macos99.0 -fsyntax-only %s -Xclang -verify=no-feature
19-
// RUN: %clang -isysroot %S/Inputs/MacOSX99.0.sdk -target x86_64-apple-macos99.0 -fsyntax-only %s -fmodules -Xclang -verify=no-feature
20-
21-
#if __has_feature(builtin_headers_in_system_modules)
22-
#error "has builtin_headers_in_system_modules"
23-
// yes-feature-error@-1 {{}}
24-
#else
25-
#error "no builtin_headers_in_system_modules"
26-
// no-feature-error@-1 {{}}
27-
#endif

0 commit comments

Comments
 (0)