Skip to content

Commit 6d4baa7

Browse files
committed
Apply clang-tidy fixes for performance-unnecessary-value-param in TileUsingInterface.cpp (NFC)
1 parent 2a6f0fb commit 6d4baa7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ struct SCFTilingResult {
7575
/// `scf.for` for iterating over the tiles.
7676
FailureOr<SCFTilingResult> tileUsingSCFForOp(RewriterBase &rewriter,
7777
TilingInterface op,
78-
SCFTilingOptions options);
78+
const SCFTilingOptions &options);
7979

8080
/// Options used to control tile + fuse.
8181
struct SCFTileAndFuseOptions {
@@ -127,9 +127,9 @@ struct SCFTileAndFuseResult {
127127
/// }
128128
/// ```
129129
FailureOr<SCFTileAndFuseResult>
130-
tileConsumerAndFuseProducerGreedilyUsingSCFForOp(RewriterBase &rewriter,
131-
TilingInterface consumer,
132-
SCFTileAndFuseOptions options);
130+
tileConsumerAndFuseProducerGreedilyUsingSCFForOp(
131+
RewriterBase &rewriter, TilingInterface consumer,
132+
const SCFTileAndFuseOptions &options);
133133

134134
/// Method to lower an `op` that implements the `TilingInterface` to
135135
/// loops/scalars.

mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ updateDestinationOperandsForTiledOp(OpBuilder &builder,
265265
/// `TilingInterface` using `scf.for` to iterate over the tiles.
266266
FailureOr<scf::SCFTilingResult>
267267
mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter, TilingInterface op,
268-
scf::SCFTilingOptions options) {
268+
const scf::SCFTilingOptions &options) {
269269
OpBuilder::InsertionGuard guard(rewriter);
270270
rewriter.setInsertionPointAfter(op);
271271

@@ -433,7 +433,7 @@ getUntiledProducerFromSliceSource(OpOperand *source,
433433
FailureOr<scf::SCFTileAndFuseResult>
434434
mlir::scf::tileConsumerAndFuseProducerGreedilyUsingSCFForOp(
435435
RewriterBase &rewriter, TilingInterface consumer,
436-
scf::SCFTileAndFuseOptions options) {
436+
const scf::SCFTileAndFuseOptions &options) {
437437
// This transformation is only valid for ops that return values (i.e. not
438438
// valid to use with operations that have memref operands).
439439
if (!consumer->getNumResults()) {

0 commit comments

Comments
 (0)