Skip to content

Commit 6de44fa

Browse files
meltqmeltq
committed
Add asinhf16 function
1 parent aae37a2 commit 6de44fa

File tree

11 files changed

+237
-1
lines changed

11 files changed

+237
-1
lines changed

‎libc/config/linux/x86_64/entrypoints.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ set(TARGET_LIBM_ENTRYPOINTS
411411
libc.src.math.acoshf
412412
libc.src.math.asinf
413413
libc.src.math.asinhf
414+
libc.src.math.asinhf16
414415
libc.src.math.atan2
415416
libc.src.math.atan2f
416417
libc.src.math.atan

‎libc/docs/headers/math/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ Higher Math Functions
257257
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
258258
| asin | |check| | | | |check| | | 7.12.4.2 | F.10.1.2 |
259259
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
260-
| asinh | |check| | | | | | 7.12.5.2 | F.10.2.2 |
260+
| asinh | |check| | | | |check| | | 7.12.5.2 | F.10.2.2 |
261261
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
262262
| asinpi | | | | | | 7.12.4.9 | F.10.1.9 |
263263
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+

‎libc/include/math.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,13 @@ functions:
5959
return_type: float
6060
arguments:
6161
- type: float
62+
- name: asinhf16
63+
standards:
64+
- stdc
65+
return_type: _Float16
66+
arguments:
67+
- type: _Float16
68+
guard: LIBC_TYPES_HAS_FLOAT16
6269
- name: atan
6370
standards:
6471
- stdc

‎libc/src/math/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ add_math_entrypoint_object(asinf16)
5454

5555
add_math_entrypoint_object(asinh)
5656
add_math_entrypoint_object(asinhf)
57+
add_math_entrypoint_object(asinhf16)
5758

5859
add_math_entrypoint_object(atan)
5960
add_math_entrypoint_object(atanf)

‎libc/src/math/asinhf16.h

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
//===-- Implementation header for asinhf16 -----------------------*- C++ -*-===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception.
6+
//
7+
//===----------------------------------------------------------------------===//
8+
9+
#ifndef LLVM_LIBC_SRC_MATH_ASINHF16_H
10+
#define LLVM_LIBC_SRC_MATH_ASINHF16_H
11+
12+
#include "src/__support/macros/config.h"
13+
#include "src/__support/macros/properties/types.h"
14+
15+
namespace LIBC_NAMESPACE_DECL {
16+
17+
float16 asinhf16(float16 x);
18+
19+
} // namespace LIBC_NAMESPACE_DECL
20+
21+
#endif // LLVM_LIBC_SRC_MATH_ASINHF16_H

‎libc/src/math/generic/CMakeLists.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,6 +3980,26 @@ add_entrypoint_object(
39803980
libc.src.__support.macros.optimization
39813981
)
39823982

3983+
add_entrypoint_object(
3984+
asinhf16
3985+
SRCS
3986+
asinhf16.cpp
3987+
HDRS
3988+
../asinhf16.h
3989+
DEPENDS
3990+
.explogxf
3991+
libc.hdr.fenv_macros
3992+
libc.src.__support.FPUtil.cast
3993+
libc.src.__support.FPUtil.fenv_impl
3994+
libc.src.__support.FPUtil.fp_bits
3995+
libc.src.__support.FPUtil.fp_bits
3996+
libc.src.__support.FPUtil.multiply_add
3997+
libc.src.__support.FPUtil.polyeval
3998+
libc.src.__support.FPUtil.sqrt
3999+
libc.src.__support.macros.optimization
4000+
libc.src.__support.macros.properties.types
4001+
)
4002+
39834003
add_entrypoint_object(
39844004
atanhf
39854005
SRCS

‎libc/src/math/generic/asinhf16.cpp

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
//===-- Half-precision asinhf16(x) function --------------------------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception.
6+
//
7+
//
8+
//===----------------------------------------------------------------------===//
9+
10+
#include "src/math/asinhf16.h"
11+
#include "src/math/generic/explogxf.h"
12+
#include "src/__support/FPUtil/except_value_utils.h"
13+
#include "src/__support/FPUtil/generic/sqrt.h"
14+
#include "src/__support/FPUtil/multiply_add.h"
15+
#include "src/__support/common.h"
16+
#include "src/__support/macros/config.h"
17+
#include "src/__support/macros/properties/types.h"
18+
19+
namespace LIBC_NAMESPACE_DECL {
20+
21+
#ifndef LIBC_MATH_HAS_SKIP_ACCURATE_PASS
22+
static constexpr size_t N_EXCEPTS = 8;
23+
24+
static constexpr fputil::ExceptValues<float16, N_EXCEPTS> ASINHF16_EXCEPTS{{
25+
// (input, RZ output, RU offset, RD offset, RN offset)
26+
{0x3769, 0x372A, 1, 0, 1},
27+
{0x3B5B, 0x3A96, 1, 0, 0},
28+
{0x4B1F, 0x42B3, 1, 0, 0},
29+
{0x4C9B, 0x4336, 1, 0, 1},
30+
{0xB769, 0xB72A, 0, 1, 1},
31+
{0xBB5B, 0xBA96, 0, 1, 0},
32+
{0xCB1F, 0xC2B3, 0, 1, 0},
33+
{0xCC9B, 0xC336, 0, 1, 1}
34+
}};
35+
#endif // !LIBC_MATH_HAS_SKIP_ACCURATE_PASS
36+
37+
LLVM_LIBC_FUNCTION(float16, asinhf16, (float16 x)) {
38+
using FPBits = fputil::FPBits<float16>;
39+
FPBits xbits(x);
40+
41+
float x_d = x;
42+
uint16_t x_u = xbits.uintval();
43+
uint16_t x_abs = x_u & 0x7fff;
44+
45+
if (LIBC_UNLIKELY(xbits.is_inf_or_nan())) {
46+
if (xbits.is_signaling_nan()) {
47+
fputil::raise_except_if_required(FE_INVALID);
48+
return FPBits::quiet_nan().get_val();
49+
}
50+
51+
return x;
52+
}
53+
54+
#ifndef LIBC_MATH_HAS_SKIP_ACCURATE_PASS
55+
// Handle exceptional values
56+
if (auto r = ASINHF16_EXCEPTS.lookup(x_u); LIBC_UNLIKELY(r.has_value()))
57+
return r.value();
58+
#endif // !LIBC_MATH_HAS_SKIP_ACCURATE_PASS
59+
60+
const float SIGN[2] = {1.0f, -1.0f};
61+
float x_sign = SIGN[x_u >> 15];
62+
63+
// |x| <= 0.25
64+
if (LIBC_UNLIKELY(x_abs <= 0x3400)) {
65+
if (LIBC_UNLIKELY(x_abs == 0))
66+
return x;
67+
if (LIBC_UNLIKELY((fputil::get_round() == FE_UPWARD) &&
68+
(x_u >= 0x8401) && (x_u <= 0x90E6)))
69+
return static_cast<float16>(x_d + 0x1p-24f);
70+
71+
float x_sq = x_d * x_d;
72+
// Generated by Sollya with:
73+
// > P = fpminimax(asinh(x)/x, [|0, 2, 4, 6, 8|], [|SG...|],[0, 2^-2]);
74+
float p = fputil::polyeval(x_sq, 1.0f, -0x1.555556p-3f, 0x1.3334dep-4f,
75+
-0x1.6f3e2p-5f, 0x1.51d012p-5f);
76+
77+
return static_cast<float16>(fputil::multiply_add(x_d, p, 0.0f));
78+
}
79+
80+
// General case: asinh(x) = ln(x + sqrt(x^2 + 1))
81+
float sqrt_term = fputil::sqrt<float>(fputil::multiply_add(x_d, x_d, 1.0f));
82+
return fputil::cast<float16>(x_sign * log_eval(
83+
fputil::multiply_add(x_d, x_sign, sqrt_term)));
84+
}
85+
}

‎libc/test/src/math/CMakeLists.txt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2175,6 +2175,18 @@ add_fp_unittest(
21752175
libc.src.__support.FPUtil.fp_bits
21762176
)
21772177

2178+
2179+
add_fp_unittest(
2180+
asinhf16_test
2181+
NEED_MPFR
2182+
SUITE
2183+
libc-math-unittests
2184+
SRCS
2185+
asinhf16_test.cpp
2186+
DEPENDS
2187+
libc.src.math.asinhf16
2188+
)
2189+
21782190
add_fp_unittest(
21792191
acoshf_test
21802192
NEED_MPFR

‎libc/test/src/math/asinhf16_test.cpp

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
//===-- Exhaustive test for asinhf16 ---------------------------------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
9+
#include "src/math/asinhf16.h"
10+
#include "test/UnitTest/FPMatcher.h"
11+
#include "test/UnitTest/Test.h"
12+
#include "utils/MPFRWrapper/MPFRUtils.h"
13+
14+
using LlvmLibcAsinhf16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
15+
16+
namespace mpfr = LIBC_NAMESPACE::testing::mpfr;
17+
18+
// Range: [0, Inf]
19+
static constexpr uint16_t POS_START = 0x0000U;
20+
static constexpr uint16_t POS_STOP = 0x7c00U;
21+
22+
// Range: [-Inf, 0]
23+
static constexpr uint16_t NEG_START = 0x8000U;
24+
static constexpr uint16_t NEG_STOP = 0xfc00U;
25+
26+
TEST_F(LlvmLibcAsinhf16Test, PositiveRange) {
27+
for (uint16_t v = POS_START; v <= POS_STOP; ++v) {
28+
float16 x = FPBits(v).get_val();
29+
30+
EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Asinh, x,
31+
LIBC_NAMESPACE::asinhf16(x), 0.5);
32+
}
33+
}
34+
35+
TEST_F(LlvmLibcAsinhf16Test, NegativeRange) {
36+
for (uint16_t v = NEG_START; v <= NEG_STOP; ++v) {
37+
float16 x = FPBits(v).get_val();
38+
39+
EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Asinh, x,
40+
LIBC_NAMESPACE::asinhf16(x), 0.5);
41+
}
42+
}

‎libc/test/src/math/smoke/CMakeLists.txt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3946,6 +3946,18 @@ add_fp_unittest(
39463946
libc.src.__support.FPUtil.fp_bits
39473947
)
39483948

3949+
add_fp_unittest(
3950+
asinhf16_test
3951+
SUITE
3952+
libc-math-smoke-tests
3953+
SRCS
3954+
asinhf16_test.cpp
3955+
DEPENDS
3956+
libc.src.errno.errno
3957+
libc.src.math.asinhf16
3958+
libc.src.__support.FPUtil.fp_bits
3959+
)
3960+
39493961
add_fp_unittest(
39503962
acoshf_test
39513963
SUITE

‎libc/test/src/math/smoke/asinhf16_test.cpp

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
//===-- Unittests for asinhf16 ----------------------------------------------===//
2+
//
3+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4+
// See https://llvm.org/LICENSE.txt for license information.
5+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6+
//
7+
//===----------------------------------------------------------------------===//
8+
9+
#include "src/errno/libc_errno.h"
10+
#include "src/math/asinhf16.h"
11+
#include "test/UnitTest/FPMatcher.h"
12+
#include "test/UnitTest/Test.h"
13+
14+
using LlvmLibcAsinhf16Test = LIBC_NAMESPACE::testing::FPTest<float16>;
15+
16+
TEST_F(LlvmLibcAsinhf16Test, SpecialNumbers) {
17+
LIBC_NAMESPACE::libc_errno = 0;
18+
EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::asinhf16(aNaN));
19+
EXPECT_MATH_ERRNO(0);
20+
21+
EXPECT_FP_EQ_WITH_EXCEPTION(aNaN, LIBC_NAMESPACE::asinhf16(sNaN), FE_INVALID);
22+
EXPECT_MATH_ERRNO(0);
23+
24+
EXPECT_FP_EQ(0.0f, LIBC_NAMESPACE::asinhf16(0.0f));
25+
EXPECT_MATH_ERRNO(0);
26+
27+
EXPECT_FP_EQ(-0.0f, LIBC_NAMESPACE::asinhf16(-0.0f));
28+
EXPECT_MATH_ERRNO(0);
29+
30+
EXPECT_FP_EQ(inf, LIBC_NAMESPACE::asinhf16(inf));
31+
EXPECT_MATH_ERRNO(0);
32+
33+
EXPECT_FP_EQ(neg_inf, LIBC_NAMESPACE::asinhf16(neg_inf));
34+
EXPECT_MATH_ERRNO(0);
35+
}

0 commit comments

Comments
 (0)