Skip to content

Commit 6ea76c1

Browse files
committed
[NFCI][RemoveDIs] Build LLVM with RemoveDIs iterators
This commit flips a bit to make LLVM build with "debuginfo iterators", causing BasicBlock::iterator to contain a bit that's used for debug-info purposes. More about this can be read on Discourse [0], but the runtime impact of this should be negligable (iterators usually end up being inlined), and there should be no change to LLVMs behaviour as a result of this commit. What this does mean though, is that roughly 400 debug-info tests where we've added "--try-experimental-debuginfo-iterators" to RUNlines are going to start operating in RemoveDIs mode. These are already tested on the new-debug-iterators buildbot [1], and I've even tested with asan, so I'm not _expecting_ any turbulence. [0] https://discourse.llvm.org/t/rfc-instruction-api-changes-needed-to-eliminate-debug-intrinsics-from-ir/68939 [1] https://lab.llvm.org/buildbot/#/builders/275
1 parent 448fe73 commit 6ea76c1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ option(LLVM_EXTERNALIZE_DEBUGINFO
654654
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
655655

656656
option(LLVM_EXPERIMENTAL_DEBUGINFO_ITERATORS
657-
"Add extra Booleans to ilist_iterators to communicate facts for debug-info" OFF)
657+
"Add extra Booleans to ilist_iterators to communicate facts for debug-info" ON)
658658

659659
set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING
660660
"Sign executables and dylibs with the given identity or skip if empty (Darwin Only)")

0 commit comments

Comments
 (0)