address comments

Author: Pierre-vh

llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h

@@ -722,8 +722,9 @@ class GIMatchTableExecutor {
   // - Fast common case handling (1 byte values).
   LLVM_ATTRIBUTE_ALWAYS_INLINE static uint64_t
   fastDecodeULEB128(const uint8_t *MatchTable, uint64_t &CurrentIdx) {
-    uint64_t Value = MatchTable[CurrentIdx] & 0x7f;
-    if (LLVM_UNLIKELY(MatchTable[CurrentIdx++] >= 128)) {
+    uint64_t Value = MatchTable[CurrentIdx++];
+    if (LLVM_UNLIKELY(Value >= 128)) {
+      Value &= 0x7f;
       unsigned Shift = 7;
       do {
         uint64_t Slice = MatchTable[CurrentIdx] & 0x7f;

llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTable.cpp

@@ -1565,7 +1565,7 @@ bool MemoryAddressSpacePredicateMatcher::isIdentical(
 
 void MemoryAddressSpacePredicateMatcher::emitPredicateOpcodes(
     MatchTable &Table, RuleMatcher &Rule) const {
-  assert(AddrSpaces.size() < 255);
+  assert(AddrSpaces.size() < 256);
   Table << MatchTable::Opcode("GIM_CheckMemoryAddressSpace")
         << MatchTable::Comment("MI") << MatchTable::ULEB128Value(InsnVarID)
         << MatchTable::Comment("MMO")