Skip to content

Commit 70900ec

Browse files
authored
[lldb][DWARFASTParserClang][NFC] Clarify comment around static member variable handling (#72495)
1 parent 667ba7f commit 70900ec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2963,9 +2963,9 @@ void DWARFASTParserClang::ParseSingleMember(
29632963
// whereas GCC emits it only for static data members if not part of an
29642964
// anonymous namespace. The flag that is consistently emitted for static
29652965
// data members is DW_AT_declaration, so we check it instead.
2966-
// FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we
2966+
// The following block is only necessary to support DWARFv4 and earlier.
2967+
// Starting with DWARFv5, static data members are marked DW_AT_variable so we
29672968
// can consistently detect them on both GCC and Clang without below heuristic.
2968-
// Remove this block if we ever drop DWARFv4 support.
29692969
if (attrs.member_byte_offset == UINT32_MAX &&
29702970
attrs.data_bit_offset == UINT64_MAX && attrs.is_declaration) {
29712971
CreateStaticMemberVariable(die, attrs, class_clang_type);

0 commit comments

Comments
 (0)