Skip to content

Commit 7117bd5

Browse files
committed
fixups
1 parent c0dce2a commit 7117bd5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

mlir/lib/Conversion/ArmSMEToLLVM/ArmSMEToLLVM.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ struct ConvertArmSMESpillsAndFillsToLLVM : public ConvertToLLVMPattern {
270270
// touches (i.e. a single tile slice).
271271
{
272272
rewriter.setInsertionPoint(op);
273-
// Swap the in-memory tile's contents into ZA before the op.
273+
// Swap the contents of ZA and the in-memory tile before the op.
274274
emitTileSwap();
275275
rewriter.setInsertionPointAfter(op);
276276
// Swap the tile back out to memory again after the op.
@@ -818,6 +818,7 @@ struct ConvertArmSMEToLLVMPass
818818
}
819819
};
820820

821+
/// Helper to register `ConvertArmSMEOpToLLVMPattern` patterns.
821822
template <typename... Pattern>
822823
static void
823824
addArmSMEConversionPatterns(RewritePatternSet &patterns,

mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,8 @@ struct AssignTileIDsPattern
235235
if (!tileIsInMemory)
236236
setDiscardableIntAttr(kTilesInUseAttr, tilesInUse);
237237
else {
238-
// If we could not find a real tile, set use a virtual tile ID (ID >= 16).
239-
// A later pass will insert the necessary spills and reloads.
238+
// If we could not find a real tile ID, use an in-memory tile ID (ID >=
239+
// 16). A later pass will insert the necessary spills and reloads.
240240
tileId =
241241
getDiscardableIntAttr(kNextInMemoryTileIdAttr, kInMemoryTileIdBase);
242242
setDiscardableIntAttr(kNextInMemoryTileIdAttr, *tileId + 1);

0 commit comments

Comments
 (0)