Skip to content

Commit 72c2cb1

Browse files
committed
[test][AArch64][CodeGen] Delete redundant CHECK-PIC lines
Since https://reviews.llvm.org/D91734, CodeGen/AArch64/elf-globals-static.ll test contains several `CHECK-PIC` lines. They do not seem to bring any value since there are no FileCheck run lines checking against this prefix. The right place for such tests should be elf-globals-pic.ll, which already contains check lines being deleted in this commit. Both elf-globals-pic.ll and elf-globals-static.ll were created after splitting arm64-elf-globals.ll in 6dbd0ea, and having `CHECK-PIC` lines in elf-globals-static.ll seems like an issue occurred because of git thinking that elf-globals-pic.ll is a new file and elf-global-static.ll is a rename of arm64-elf-globals.ll
1 parent 110c22f commit 72c2cb1

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/test/CodeGen/AArch64/elf-globals-static.ll

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ define i8 @test_i8(i8 %new) {
1515
; CHECK: ldrb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]
1616
; CHECK: strb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]
1717

18-
; CHECK-PIC-LABEL: test_i8:
19-
; CHECK-PIC: adrp x[[HIREG:[0-9]+]], :got:var8
20-
; CHECK-PIC: ldr x[[VAR_ADDR:[0-9]+]], [x[[HIREG]], :got_lo12:var8]
21-
; CHECK-PIC: ldrb {{w[0-9]+}}, [x[[VAR_ADDR]]]
22-
2318
; CHECK-FAST-LABEL: test_i8:
2419
; CHECK-FAST: adrp x[[HIREG:[0-9]+]], var8
2520
; CHECK-FAST: ldrb {{w[0-9]+}}, [x[[HIREG]], :lo12:var8]

0 commit comments

Comments
 (0)