Skip to content

Commit 738cc71

Browse files
Remove library file name from the repro call.
Since the pass injects all definitions, providing the library again isn't needed. Since that injection isn't idempotent, it actually isn't even *possible* anymore, so this commits removes that argument.
1 parent 8c63dc0 commit 738cc71

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

mlir/lib/Dialect/Transform/Transforms/TransformInterpreterPassBase.cpp

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -163,17 +163,9 @@ static llvm::raw_ostream &
163163
printReproCall(llvm::raw_ostream &os, StringRef rootOpName, StringRef passName,
164164
const Pass::Option<std::string> &debugPayloadRootTag,
165165
const Pass::Option<std::string> &debugTransformRootTag,
166-
const Pass::Option<std::string> &transformLibraryFileName,
167166
StringRef binaryName) {
168-
std::string transformLibraryOption = "";
169-
if (!transformLibraryFileName.empty()) {
170-
transformLibraryOption =
171-
llvm::formatv(" {0}={1}", transformLibraryFileName.getArgStr(),
172-
transformLibraryFileName.getValue())
173-
.str();
174-
}
175167
os << llvm::formatv(
176-
"{7} --pass-pipeline=\"{0}({1}{{{2}={3} {4}={5}{6}})\"", rootOpName,
168+
"{6} --pass-pipeline=\"{0}({1}{{{2}={3} {4}={5}})\"", rootOpName,
177169
passName, debugPayloadRootTag.getArgStr(),
178170
debugPayloadRootTag.empty()
179171
? StringRef(kTransformDialectTagPayloadRootValue)
@@ -182,7 +174,7 @@ printReproCall(llvm::raw_ostream &os, StringRef rootOpName, StringRef passName,
182174
debugTransformRootTag.empty()
183175
? StringRef(kTransformDialectTagTransformContainerValue)
184176
: debugTransformRootTag,
185-
transformLibraryOption, binaryName);
177+
binaryName);
186178
return os;
187179
}
188180

@@ -228,8 +220,7 @@ void saveReproToTempFile(
228220

229221
os << "=== Transform Interpreter Repro ===\n";
230222
printReproCall(os, root->getName().getStringRef(), passName,
231-
debugPayloadRootTag, debugTransformRootTag,
232-
transformLibraryFileName, binaryName)
223+
debugPayloadRootTag, debugTransformRootTag, binaryName)
233224
<< " " << filename << "\n";
234225
os << "===================================\n";
235226
}
@@ -283,8 +274,7 @@ static void performOptionalDebugActions(
283274
llvm::dbgs() << "=== Transform Interpreter Repro ===\n";
284275
printReproCall(llvm::dbgs() << "cat <<EOF | ",
285276
root->getName().getStringRef(), passName,
286-
debugPayloadRootTag, debugTransformRootTag,
287-
transformLibraryFileName, binaryName)
277+
debugPayloadRootTag, debugTransformRootTag, binaryName)
288278
<< "\n";
289279
printModuleForRepro(llvm::dbgs(), root, transform);
290280
llvm::dbgs() << "\nEOF\n";

0 commit comments

Comments
 (0)