Skip to content

Commit 7434ac9

Browse files
committed
[NFC] Fixup comments
1 parent 22e0cac commit 7434ac9

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

llvm/lib/TargetParser/AArch64TargetParser.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,11 @@ void AArch64::ExtensionSet::disable(ArchExtKind E) {
253253
disable(AEK_SM4);
254254
}
255255

256-
// sve2-aes was historically associated with both FEAT_SVE2 and FEAT_SVE_AES, the latter
257-
// is now associated with sve-aes and sve2-aes has become shorthand for +sve2+sve-aes.
258-
// For backwards compatibility, when we disable sve2-aes we must also disable sve-aes.
259-
if(E == AEK_SVE2AES)
256+
// sve2-aes was historically associated with both FEAT_SVE2 and FEAT_SVE_AES,
257+
// the latter is now associated with sve-aes and sve2-aes has become shorthand
258+
// for +sve2+sve-aes. For backwards compatibility, when we disable sve2-aes we
259+
// must also disable sve-aes.
260+
if (E == AEK_SVE2AES)
260261
disable(AEK_SVEAES);
261262

262263
if (!Enabled.test(E))

llvm/test/MC/AArch64/SVE2/directive-arch-negative.s

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ aesd z23.b, z23.b, z13.b
1111
// CHECK: error: instruction requires: sve-aes
1212
// CHECK-NEXT: aesd z23.b, z23.b, z13.b
1313

14+
// nosve2-aes should disable sve-aes but not sve2.
1415
.arch armv9-a+sve2-aes+nosve2-aes
1516
aesd z23.b, z23.b, z13.b
1617
// CHECK: error: instruction requires: sve-aes

llvm/test/MC/AArch64/SVE2/directive-arch_extension-negative.s

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ aesd z23.b, z23.b, z13.b
1212
// CHECK: error: instruction requires: sve2 sve-aes
1313
// CHECK-NEXT: aesd z23.b, z23.b, z13.b
1414

15+
// nosve2-aes should disable sve-aes but not sve2.
1516
.arch_extension sve2-aes
1617
.arch_extension nosve2-aes
1718
aesd z23.b, z23.b, z13.b

llvm/test/MC/AArch64/SVE2/directive-cpu-negative.s

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ tbx z0.b, z1.b, z2.b
66
// CHECK: error: instruction requires: sve2 or sme
77
// CHECK-NEXT: tbx z0.b, z1.b, z2.b
88

9+
// nosve2-aes should disable sve-aes but not sve2.
910
.cpu generic+sve2-aes+nosve2-aes
1011
aesd z23.b, z23.b, z13.b
1112
// CHECK: error: instruction requires: sve-aes

0 commit comments

Comments
 (0)