[JSON][NFC] Move print method out of NDEBUG || DUMP (#131639)

npanchen · web-flow · commit 745e16753fc1 · 2025-03-17T21:12:07.000-04:00
diff --git a/llvm/include/llvm/Support/JSON.h b/llvm/include/llvm/Support/JSON.h
@@ -472,8 +472,8 @@ class Value {
     return LLVM_LIKELY(Type == T_Array) ? &as<json::Array>() : nullptr;
   }
 
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
   void print(llvm::raw_ostream &OS) const;
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
   LLVM_DUMP_METHOD void dump() const {
     print(llvm::dbgs());
     llvm::dbgs() << '\n';
diff --git a/llvm/lib/Support/JSON.cpp b/llvm/lib/Support/JSON.cpp
@@ -182,9 +182,7 @@ void Value::destroy() {
   }
 }
 
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
 void Value::print(llvm::raw_ostream &OS) const { OS << *this; }
-#endif // !NDEBUG || LLVM_ENABLE_DUMP
 
 bool operator==(const Value &L, const Value &R) {
   if (L.kind() != R.kind())

Original file line number	Diff line number	Diff line change
`@@ -472,8 +472,8 @@ class Value {`
`472`	`472`	`return LLVM_LIKELY(Type == T_Array) ? &as<json::Array>() : nullptr;`
`473`	`473`	`}`
`474`	`474`
`475`		`-#if !defined(NDEBUG) \|\| defined(LLVM_ENABLE_DUMP)`
`476`	`475`	`void print(llvm::raw_ostream &OS) const;`
	`476`	`+#if !defined(NDEBUG) \|\| defined(LLVM_ENABLE_DUMP)`
`477`	`477`	`LLVM_DUMP_METHOD void dump() const {`
`478`	`478`	`print(llvm::dbgs());`
`479`	`479`	`llvm::dbgs() << '\n';`
Original file line number	Diff line number	Diff line change
`@@ -182,9 +182,7 @@ void Value::destroy() {`
`182`	`182`	`}`
`183`	`183`	`}`
`184`	`184`
`185`		`-#if !defined(NDEBUG) \|\| defined(LLVM_ENABLE_DUMP)`
`186`	`185`	`void Value::print(llvm::raw_ostream &OS) const { OS << *this; }`
`187`		`-#endif // !NDEBUG \|\| LLVM_ENABLE_DUMP`
`188`	`186`
`189`	`187`	`bool operator==(const Value &L, const Value &R) {`
`190`	`188`	`if (L.kind() != R.kind())`