Skip to content

Commit 74a102f

Browse files
authored
[libcxx] [test] Change an MSVC mode XFAIL into UNSUPPORTED (#141609)
The underlying bug in vcruntime [1] has been fixed in the latest version of MSVC (released two weeks ago); this will cause the test which is currently marked XFAIL to start erroring, when it starts passing unexpectedly. This version of MSVC may soon start appearing in the Github Actions runner images used for our CI. We could try to detect the state of this bug, but in practice, such detection code would essentially be a copy of this whole test. Therefore, just mark this test UNSUPPORTED for the MSVC mode builds. If we at some point require new enough MSVC libraries, we could remove the marking entirely. [1] https://developercommunity.visualstudio.com/t/vcruntime-nothrow-array-operator-new-fal/10373274
1 parent 27675cc commit 74a102f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new.size_nothrow.replace.indirect.pass.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@
2121
// MSVC/vcruntime falls back from the nothrow array new to the nothrow
2222
// scalar new, instead of falling back on the throwing array new.
2323
// https://developercommunity.visualstudio.com/t/vcruntime-nothrow-array-operator-new-fal/10373274
24-
// XFAIL: target={{.+}}-windows-msvc
24+
// This issue got fixed in MSVC 2022 17.14; with vcruntime from that version,
25+
// this test does pass. (We could try to detect it and set a feature for when
26+
// this is known broken, but that detection would essentially a copy of this
27+
// test.)
28+
// UNSUPPORTED: target={{.+}}-windows-msvc
2529

2630
#include <new>
2731
#include <cstddef>

0 commit comments

Comments
 (0)