Skip to content

Commit 7581cb6

Browse files
[lldb] Remove lldb-server min and max gdbserver port options (#133275)
Since lldb 20, these have had no effect: https://releases.llvm.org/20.1.0/docs/ReleaseNotes.html#changes-to-lldb > lldb-server now listens to a single port for gdbserver connections and > provides that port to the connection handler processes. This means that > only 2 ports need to be opened in the firewall (one for the lldb-server > platform, one for gdbserver connections). In addition, due to this work, lldb-server now works on Windows in the server mode. Remove them.
1 parent da5fb42 commit 7581cb6

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lldb/tools/lldb-server/lldb-platform.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ static struct option g_long_options[] = {
6767
{"log-channels", required_argument, nullptr, 'c'},
6868
{"listen", required_argument, nullptr, 'L'},
6969
{"gdbserver-port", required_argument, nullptr, 'P'},
70-
{"min-gdbserver-port", required_argument, nullptr, 'm'},
71-
{"max-gdbserver-port", required_argument, nullptr, 'M'},
7270
{"socket-file", required_argument, nullptr, 'f'},
7371
{"server", no_argument, &g_server, 1},
7472
{"child-platform-fd", required_argument, nullptr, 2},

llvm/docs/ReleaseNotes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,9 @@ Changes to LLDB
220220
information about the current state of the debugger at the bottom of the
221221
terminal. This is on by default and can be configured using the
222222
`show-statusline` and `statusline-format` settings.
223+
* The `min-gdbserver-port` and `max-gdbserver-port` options have been removed
224+
from `lldb-server`'s platform mode. Since the changes to `lldb-server`'s port
225+
handling in LLDB 20, these options have had no effect.
223226

224227
### Changes to lldb-dap
225228

0 commit comments

Comments
 (0)