Skip to content

Commit 76b8754

Browse files
committed
Revert "Reapply "[clang][deps] Support inferred modules""
This reverts commit c98833c. The test `ClangScanDeps/modules-inferred-explicit-build.m` creates files in the current directory.
1 parent f66ba4c commit 76b8754

File tree

11 files changed

+5
-200
lines changed

11 files changed

+5
-200
lines changed

clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ makeInvocationForModuleBuildWithoutPaths(const ModuleDeps &Deps,
3333
CI.getFrontendOpts().IsSystemModule = Deps.IsSystem;
3434

3535
CI.getLangOpts()->ImplicitModules = false;
36+
CI.getHeaderSearchOpts().ImplicitModuleMaps = false;
3637

3738
return CI;
3839
}
@@ -178,22 +179,13 @@ ModuleID ModuleDepCollectorPP::handleTopLevelModule(const Module *M) {
178179
const FileEntry *ModuleMap = Instance.getPreprocessor()
179180
.getHeaderSearchInfo()
180181
.getModuleMap()
181-
.getModuleMapFileForUniquing(M);
182+
.getContainingModuleMapFile(M);
182183
MD.ClangModuleMapFile = std::string(ModuleMap ? ModuleMap->getName() : "");
183184

184185
serialization::ModuleFile *MF =
185186
MDC.Instance.getASTReader()->getModuleManager().lookup(M->getASTFile());
186187
MDC.Instance.getASTReader()->visitInputFiles(
187188
*MF, true, true, [&](const serialization::InputFile &IF, bool isSystem) {
188-
// __inferred_module.map is the result of the way in which an implicit
189-
// module build handles inferred modules. It adds an overlay VFS with
190-
// this file in the proper directory and relies on the rest of Clang to
191-
// handle it like normal. With explicitly built modules we don't need
192-
// to play VFS tricks, so replace it with the correct module map.
193-
if (IF.getFile()->getName().endswith("__inferred_module.map")) {
194-
MD.FileDeps.insert(ModuleMap->getName());
195-
return;
196-
}
197189
MD.FileDeps.insert(IF.getFile()->getName());
198190
});
199191

clang/test/ClangScanDeps/Inputs/frameworks/Inferred.framework/Frameworks/Sub.framework/Headers/Sub.h

Whitespace-only changes.

clang/test/ClangScanDeps/Inputs/frameworks/Inferred.framework/Headers/Inferred.h

Lines changed: 0 additions & 1 deletion
This file was deleted.

clang/test/ClangScanDeps/Inputs/frameworks/System.framework/Headers/System.h

Lines changed: 0 additions & 1 deletion
This file was deleted.

clang/test/ClangScanDeps/Inputs/frameworks/System.framework/Modules/module.modulemap

Lines changed: 0 additions & 3 deletions
This file was deleted.

clang/test/ClangScanDeps/Inputs/frameworks/module.modulemap

Lines changed: 0 additions & 1 deletion
This file was deleted.

clang/test/ClangScanDeps/Inputs/modules_inferred_cdb.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

clang/test/ClangScanDeps/modules-full.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
// CHECK: "-emit-module"
4949
// CHECK-NO-ABS-NOT: "-fmodule-file={{.*}}"
5050
// CHECK-ABS: "-fmodule-file=[[PREFIX]]/module-cache{{(_clangcl)?}}/[[CONTEXT_HASH_H1]]/header2-{{[A-Z0-9]+}}.pcm"
51+
// CHECK-NOT: "-fimplicit-module-maps"
5152
// CHECK: "-fmodule-name=header1"
5253
// CHECK: "-fno-implicit-modules"
5354
// CHECK: ],
@@ -64,6 +65,7 @@
6465
// CHECK-NEXT: "command-line": [
6566
// CHECK-NEXT: "-cc1",
6667
// CHECK: "-emit-module",
68+
// CHECK-NOT: "-fimplicit-module-maps",
6769
// CHECK: "-fmodule-name=header1",
6870
// CHECK: "-fno-implicit-modules",
6971
// CHECK: ],
@@ -80,6 +82,7 @@
8082
// CHECK-NEXT: "command-line": [
8183
// CHECK-NEXT: "-cc1",
8284
// CHECK: "-emit-module",
85+
// CHECK-NOT: "-fimplicit-module-maps",
8386
// CHECK: "-fmodule-name=header2",
8487
// CHECK: "-fno-implicit-modules",
8588
// CHECK: ],

clang/test/ClangScanDeps/modules-inferred-explicit-build.m

Lines changed: 0 additions & 22 deletions
This file was deleted.

clang/test/ClangScanDeps/modules-inferred.m

Lines changed: 0 additions & 61 deletions
This file was deleted.

clang/utils/module-deps-to-rsp.py

Lines changed: 0 additions & 94 deletions
This file was deleted.

0 commit comments

Comments
 (0)