Skip to content

Commit 76d7227

Browse files
committed
[lldb][Minidump] Fix MAX_WRITE_CHUNK_SIZE type
MinidumpFileBuilder calls std::min(MAX_WRITE_CHUNK_SIZE, func_returning_uint64_t) and on Darwin this errors out with unsigned long long & unsigned long not being the same type.
1 parent 1a1698b commit 76d7227

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class MinidumpFileBuilder {
171171
// but we want to try to keep the size of m_data small
172172
// and we will only exceed a 128 mb buffer if we get a memory region
173173
// that is larger than 128 mb.
174-
static constexpr size_t MAX_WRITE_CHUNK_SIZE = (1024 * 1024 * 128);
174+
static constexpr uint64_t MAX_WRITE_CHUNK_SIZE = (1024 * 1024 * 128);
175175

176176
static constexpr size_t HEADER_SIZE = sizeof(llvm::minidump::Header);
177177
static constexpr size_t DIRECTORY_SIZE = sizeof(llvm::minidump::Directory);

0 commit comments

Comments
 (0)